Draggable: issue with containment on position:fixed elements

[gethinw]

If an element is position:fixed and made draggable with containment:'window' the containment isn't applied correctly when the page is scrolled.

See ​http://jsfiddle.net/JVn7P/

[jfremy]

The following fix did it for me (I did not test thoroughly). In _setContainment, use the following code:

if(o.containment == 'document' || o.containment == 'window') this.containment = [
	o.containment == 'document' ? 0 : $(window).scrollLeft() - this.offset.relative.left - this.offset.parent.left,
	o.containment == 'document' ? 0 : $(window).scrollTop() - this.offset.relative.top - this.offset.parent.top,
	o.containment == 'document' ? 0 : $(window).scrollLeft() + $(o.containment == 'document' ? document : window).width() - this.helperProportions.width - this.margins.left,
	o.containment == 'document' ? 0 : $(window).scrollTop() + ($(o.containment == 'document' ? document : window).height() || document.body.parentNode.scrollHeight) - this.helperProportions.height - this.margins.top
];

When containment is "window", use scrollTop and scrollLeft to shift the containment window accordingly.

The problem also manifests itself with position:absolute. If you take the fiddle sample and switch from fixed to absolute, then if you move the block down, then scroll and then try to move the block again, it will jump up.

[jfremy]

​https://github.com/jfremy/jquery-ui/commit/62f3f77e51e95aca31e53d9d7646cc41b8de06e2

We'll see if this is accepted

[Jean-Francois Remy]

Draggable: Handle scrolled windows. Fixes #6181 - Draggable: issue with containment on position:fixed elements.

Changeset: e01664a3820c185636a3fe7099e93e68091d24fd

[scottgonzalez]

Milestone TBD deleted