#6634 closed bug (fixed)

Opened November 08, 2010 01:26PM UTC

Closed November 19, 2010 03:59PM UTC

Last modified December 08, 2010 06:37PM UTC

minified css does not @include minified css files

Reported by: WanderingZombie Owned by:
Priority: minor Milestone: 1.8.7
Component: [meta] ui.build Version: 1.8.6
Keywords: Cc:
Blocked by: Blocking:
Description

themes/base/minified/jquery.ui.all.min.css

@import "jquery.ui.base.css";@import "jquery.ui.theme.css";

Clearly this is not what the user intended when referencing a minified file. It should be :

@import "jquery.ui.base.min.css";@import "jquery.ui.theme.min.css";

OR, as minified files are in a directory named minified, there's no real need to change the filename of each .css file.

Attachments (0)
Change History (5)

Changed November 08, 2010 01:36PM UTC by jzaefferer comment:1

milestone: TBD → 1.9

Good catch. Missed that when adding minified CSS files.

Changed November 08, 2010 01:37PM UTC by jzaefferer comment:2

component: ui.core → [meta] ui.build

Changed November 19, 2010 03:35PM UTC by jzaefferer comment:3

This does the trick, put into minify target:

		<replaceregexp match=".css" replace=".min.css" flags="g">
			<fileset dir="${dist.dir}/themes/base/minified/">
				<include name="*.base.min.css"/>
				<include name="*.all.min.css"/>
			</fileset>
		</replaceregexp>

Changed November 19, 2010 03:59PM UTC by jzaefferer comment:4

resolution: → fixed
status: new → closed

Build: Replace filename references in base/all.min.css. Fixes #6634 - minified css does not @include minified css files.

Also make a copy of images to fix relative paths.

Changeset: 812c274a3376c4fee4d9705628a629d185bc86a9

Changed December 08, 2010 06:37PM UTC by scottgonzalez comment:5

milestone: 1.9 → 1.8.7