#6669 closed bug (wontfix)

Opened November 18, 2010 02:47PM UTC

Closed August 10, 2011 12:00PM UTC

Datepicker _selectDate invalid restore focus

Reported by: djmadcat Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.datepicker Version: 1.8.6
Keywords: Cc:
Blocked by: Blocking:
Description

Method: _selectDate

Line: 896

Code:

if (typeof(inst.input[0]) != 'object')

Supposably must be:

if (typeof(inst.input[0]) == 'object')

Probably, inequality is wrong. We can't restore focus to non-object.

Attachments (0)
Change History (8)

Changed May 25, 2011 05:41AM UTC by marcneuwirth comment:1

Datepicker: Check if typeof input === 'object' Fixed #6669 - Datepicker: _selectDate restores focus to non-object

Submitted pull request: https://github.com/jquery/jquery-ui/pull/337

Changed June 22, 2011 09:05AM UTC by marcneuwirth comment:2

resolution: → fixed
status: new → closed

Datepicker: Removing unnessecary typeof check. Fixed #6669 - Datepicker: _selectDate restores focus to non-object

Changeset: 5f0a2f01c4609315ab66158191d3f9bd420f827f

Changed June 27, 2011 10:07PM UTC by marcneuwirth comment:3

Datepicker: Removing unnessecary typeof check. Fixed #6669 - Datepicker: _selectDate restores focus to non-object

Changeset: 86a09aeb332851971bc2b2ce6bbf4d4292b12020

Changed June 27, 2011 10:08PM UTC by gnarf comment:4

milestone: TBD → 1.8.15

Changed August 10, 2011 11:56AM UTC by Scott González comment:5

Datepicker: Revert "Datepicker: Removing unnessecary typeof check. Fixed #6669 - Datepicker: _selectDate restores focus to non-object" Fixes #7623 - DatePicker reappears after selection in ie8.

This reverts commit 5f0a2f01c4609315ab66158191d3f9bd420f827f.

Changeset: bb79b418717bbd4b2ae800fc8c6bbe39682a2283

Changed August 10, 2011 11:58AM UTC by Scott González comment:6

Datepicker: Revert "Datepicker: Removing unnessecary typeof check. Fixed #6669 - Datepicker: _selectDate restores focus to non-object" Fixes #7623 - DatePicker reappears after selection in ie8.

This reverts commit 86a09aeb332851971bc2b2ce6bbf4d4292b12020.

Changeset: 7c15d3c19f9cdde9cc82ac0486a93b01ec03eb6b

Changed August 10, 2011 11:58AM UTC by scottgonzalez comment:7

milestone: 1.8.15 → 1.9
resolution: fixed
status: closed → reopened

Changed August 10, 2011 12:00PM UTC by scottgonzalez comment:8

resolution: → wontfix
status: reopened → closed

Closing this as wontfix. The fix was actually wrong, since it changed behavior. While the code appears to make no sense, the correct fix would've been to delete the code, not remove the conditional. Since datepicker has functioned this way for a very long time and we're rewriting this from scratch, and no actual bug is reported here, I'd rather not do anything about this.