Opened 13 years ago

Closed 12 years ago

#6669 closed bug (wontfix)

Datepicker _selectDate invalid restore focus

Reported by: djmadcat Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.datepicker Version: 1.8.6
Keywords: Cc:
Blocked by: Blocking:

Description

Method: _selectDate
Line: 896

Code:
if (typeof(inst.input[0]) != 'object')

Supposably must be:
if (typeof(inst.input[0]) == 'object')

Probably, inequality is wrong. We can't restore focus to non-object.

Change History (8)

comment:1 Changed 12 years ago by marcneuwirth

Datepicker: Check if typeof input === 'object' Fixed #6669 - Datepicker: _selectDate restores focus to non-object

Submitted pull request: ​https://github.com/jquery/jquery-ui/pull/337

comment:2 Changed 12 years ago by marcneuwirth

Resolution: → fixed
Status: new → closed

Datepicker: Removing unnessecary typeof check. Fixed #6669 - Datepicker: _selectDate restores focus to non-object

Changeset: 5f0a2f01c4609315ab66158191d3f9bd420f827f

comment:3 Changed 12 years ago by marcneuwirth

Datepicker: Removing unnessecary typeof check. Fixed #6669 - Datepicker: _selectDate restores focus to non-object

Changeset: 86a09aeb332851971bc2b2ce6bbf4d4292b12020

comment:4 Changed 12 years ago by Corey Frang

Milestone: TBD → 1.8.15

comment:5 Changed 12 years ago by Scott González

Datepicker: Revert "Datepicker: Removing unnessecary typeof check. Fixed #6669 - Datepicker: _selectDate restores focus to non-object" Fixes #7623 - DatePicker reappears after selection in ie8.

This reverts commit 5f0a2f01c4609315ab66158191d3f9bd420f827f.

Changeset: bb79b418717bbd4b2ae800fc8c6bbe39682a2283

comment:6 Changed 12 years ago by Scott González

Datepicker: Revert "Datepicker: Removing unnessecary typeof check. Fixed #6669 - Datepicker: _selectDate restores focus to non-object" Fixes #7623 - DatePicker reappears after selection in ie8.

This reverts commit 86a09aeb332851971bc2b2ce6bbf4d4292b12020.

Changeset: 7c15d3c19f9cdde9cc82ac0486a93b01ec03eb6b

comment:7 Changed 12 years ago by Scott González

Milestone: 1.8.15 → 1.9
Resolution: fixed
Status: closed → reopened

comment:8 Changed 12 years ago by Scott González

Resolution: → wontfix
Status: reopened → closed

Closing this as wontfix. The fix was actually wrong, since it changed behavior. While the code appears to make no sense, the correct fix would've been to delete the code, not remove the conditional. Since datepicker has functioned this way for a very long time and we're rewriting this from scratch, and no actual bug is reported here, I'd rather not do anything about this.

Note: See TracTickets for help on using tickets.