#6792 closed feature (duplicate)

Opened December 30, 2010 04:24PM UTC

Closed November 30, 2012 11:47AM UTC

Dialog title bar (.ui-dialog .ui-dialog-titlebar) typesetting inconsistent with other widgets

Reported by: AaronP Owned by:
Priority: minor Milestone: 1.10.0
Component: ui.dialog Version: 1.8.7
Keywords: Cc:
Blocked by: Blocking:
Description

The dialog titlebar type seems to be set too low. An even .4em on top and bottom still achieves a total padding height of .8em but sets the type correctly and more consistently with other widgets (note typesetting on accordion header, for example). I can't find mention of this on the forum or in past tickets. Current css uses this padding on the div:

.ui-dialog .ui-dialog-titlebar {
    padding: 0.5em 1em 0.3em;
    position: relative;
}

and this margin on the child span:

.ui-dialog .ui-dialog-title {
   margin: 0.1em 16px 0.2em 0;
}

Sent pull request on github.

Attachments (0)
Change History (5)

Changed May 12, 2011 09:33PM UTC by RobLoach comment:1

In a related note, there's an extra whitespace at the end of .ui-dialog-title:

.ui-dialog .ui-dialog-titlebar { padding: .4em 1em; position: relative;  }
.ui-dialog .ui-dialog-title { float: left; margin: .1em 16px .1em 0; } 
.ui-dialog .ui-dialog-titlebar-close { position: absolute; right: .3em; top: 50%; width: 19px; margin: -10px 0 0 0; padding: 1px; height: 18px; }

Changed June 26, 2012 01:22AM UTC by scottgonzalez comment:2

type: enhancement → feature

Changed October 11, 2012 02:13PM UTC by scottgonzalez comment:3

component: CSS Framework → ui.dialog
milestone: 1.9.0 → 1.10.0

Changed October 15, 2012 06:37PM UTC by bavanyo comment:4

status: new → open

Changed November 30, 2012 11:47AM UTC by jzaefferer comment:5

resolution: → duplicate
status: open → closed

Duplicate of #6832.Closing as duplicate of #6832, as that was fixed a long time ago. Not sure why that ticket was created and referenced though, it should have pointed at this one.