#6948 closed bug (fixed)

Opened February 06, 2011 07:28PM UTC

Closed May 10, 2011 02:53PM UTC

Last modified May 10, 2011 02:53PM UTC

Resizable autoHide Doesn't Work With Resizable's disable

Reported by:	machineghost	Owned by:
Priority:	minor	Milestone:	1.8.13
Component:	ui.resizable	Version:	1.8.9
Keywords:		Cc:
Blocked by:		Blocking:

Description

Ticket #3237 already has all the description of this issue, as well as code for a fix (in a comment I just added), but I don't have the power to re-open that issue, and I don't want this easily-fixable bug to get missed, so I'm filing this dupe. Hopefully someone with higher privileges can delete this bug as a dupe and instead re-open (or at the very least respond to) that one. Thanks!

Attachments (0)

Change History (7)

Changed February 06, 2011 07:30PM UTC by machineghost comment:1

Doh, and I filed it under the wrong component, sorry. Unfortunately I can't fix it because (even though I created this ticket) I don't have permissions to modify it. Sorry for the inconvenience; y'all really might want to consider slightly loosening edit permissions (at least on stuff people just filed two seconds ago) :-)

Changed February 06, 2011 07:32PM UTC by scottgonzalez comment:2

component:	ui.core → ui.resizable
status:	new → open

Changed February 06, 2011 07:46PM UTC by machineghost comment:3

_comment0:	Scott suggested that I file a new bug for this, and since I already have, so please do not close this as a dupe after all. However, please do refer to my comment on 3237 about both the issue and the fix. Also, please refer to my follow up comment which explains that I'm a moron who submitted a bad fix; the real fix shouldn't have .parent, so it should be a matter of changing ... \ \ {{{ \ .hover(function() { \ $(this).removeClass("ui-resizable-autohide"); \ self._handles.show(); \ }, \ function(){ \ if (!self.resizing) { \ $(this).addClass("ui-resizable-autohide"); \ self._handles.hide(); \ } \ }); \ }}} \ \ to: \ \ {{{ \ .hover(function() { \ if ($(this).is(".ui-resizable-disabled")) return; \ $(this).removeClass("ui-resizable-autohide"); \ self._handles.show(); \ }, \ function(){ \ if ($(this).is(".ui-resizable-disabled")) return; \ if (!self.resizing) { \ $(this).addClass("ui-resizable-autohide"); \ self._handles.hide(); \ } \ }); \ }}} \ → 1297021646097097

_comment0:

Scott suggested that I file a new bug for this, and since I already have, so please do not close this as a dupe after all. However, please do refer to my comment on 3237 about both the issue and the fix. Also, please refer to my follow up comment which explains that I'm a moron who submitted a bad fix; the real fix shouldn't have .parent, so it should be a matter of changing ... \ \ {{{ \ .hover(function() { \ $(this).removeClass("ui-resizable-autohide"); \ self._handles.show(); \ }, \ function(){ \ if (!self.resizing) { \ $(this).addClass("ui-resizable-autohide"); \ self._handles.hide(); \ } \ }); \ }}} \ \ to: \ \ {{{ \ .hover(function() { \ if ($(this).is(".ui-resizable-disabled")) return; \ $(this).removeClass("ui-resizable-autohide"); \ self._handles.show(); \ }, \ function(){ \ if ($(this).is(".ui-resizable-disabled")) return; \ if (!self.resizing) { \ $(this).addClass("ui-resizable-autohide"); \ self._handles.hide(); \ } \ }); \ }}} \ → 1297021646097097

Scott suggested that I file a new bug for this, and since I already have, please do not close this as a dupe after all. However, please do refer to my comment on 3237 about both the issue and the fix. Also, please refer to my follow up comment which explains that I'm a moron who submitted a bad fix; the real fix shouldn't have .parent, so it should be a matter of changing ...

.hover(function() {
	$(this).removeClass("ui-resizable-autohide");
	self._handles.show();
},
function(){
	if (!self.resizing) {
		$(this).addClass("ui-resizable-autohide");
		self._handles.hide();
	}
});

to:

.hover(function() {
	if ($(this).is(".ui-resizable-disabled")) return;
	$(this).removeClass("ui-resizable-autohide");
	self._handles.show();
},
function(){
	if ($(this).is(".ui-resizable-disabled")) return;
	if (!self.resizing) {
		$(this).addClass("ui-resizable-autohide");
		self._handles.hide();
	}
});

Changed February 06, 2011 07:46PM UTC by machineghost comment:4

P.S. Thanks Scott, sorry for the mess.

Changed May 06, 2011 08:00PM UTC by carson comment:5

_comment0:	Created a demo of the issue here: http://jsfiddle.net/A46AY/ \ \ Commit to fix is here: https://github.com/carsonmcdonald/jquery-ui/commit/ba82f05120a2c69efda3a7716d58942c9826346a → 1304954407617220

Created a demo of the issue here: http://jsfiddle.net/A46AY/

Commit to fix is here: https://github.com/carsonmcdonald/jquery-ui/commit/0e2bc5efe217681c006ae7a16be21520e6563da6

Changed May 10, 2011 02:53PM UTC by Carson McDonald comment:6

resolution:	→ fixed
status:	open → closed

Resizable: Skip autohide hover action when resizable is disabled. Fix #6948 - Resizable autoHide Doesn't Work With Resizable's disable

(cherry picked from commit 0e2bc5efe217681c006ae7a16be21520e6563da6)

Changeset: 38af07ec4e916bc5fe1268b9878a21801368a78d

Changed May 10, 2011 02:53PM UTC by scottgonzalez comment:7

milestone:	1.9 → 1.8.13

Search and Top Navigation