#6966 closed bug (fixed)

Opened February 10, 2011 10:31PM UTC

Closed March 08, 2011 02:43PM UTC

Last modified August 02, 2011 05:31PM UTC

Pressing ESC on dialog when 2 dialogs are open closes both dialogs

Reported by: fracmak Owned by:
Priority: minor Milestone: 1.8.16
Component: ui.dialog Version: 1.8.9
Keywords: Cc:
Blocked by: Blocking:
Description

The correct behavior is to only close the active dialog.

Attachments (0)
Change History (10)

Changed February 10, 2011 10:44PM UTC by fracmak comment:1

A pull request has been made that fixes this issue.

Changed February 25, 2011 03:56PM UTC by fracmak comment:2

pull request: https://github.com/jquery/jquery-ui/pull/117

Changed March 07, 2011 01:20PM UTC by scottgonzalez comment:3

_comment0: The pull request can land if we can get core to fix the problem where native events don't carry properties over properly when bubbling (see pull request for details). → 1299508141408387
status: new → open

The new pull request can land if we can get core to fix the problem where native events don't carry properties over properly when bubbling (see pull request for details).

Changed March 08, 2011 02:43PM UTC by Jay Merrifield comment:4

resolution: → fixed
status: open → closed

Dialog: Before handling escape key presses, check if the default action has been prevented. Fixes #6966 - Pressing ESC on dialog when 2 dialogs are open closes both dialogs.

Changeset: f9996682b5739661c21548f0de3d4c4883c5119d

Changed June 08, 2011 01:48AM UTC by scottgonzalez comment:5

#5365 is a duplicate of this ticket.

Changed June 09, 2011 06:40PM UTC by scottgonzalez comment:6

#3539 is a duplicate of this ticket.

Changed August 02, 2011 04:45PM UTC by andreaspelme comment:7

This is not applied in the latest 1-8-stable tree. Why? It seems a pure bug fix and something that just bit me. The fix seems to be trivial to include in the 1-8-stable branch.

Here is a pull request for 1-8-stable with the patch backported: https://github.com/jquery/jquery-ui/pull/415

Changed August 02, 2011 05:29PM UTC by Andreas Pelme comment:8

Backport of f9996682b5739661c21548f0de3d4c4883c5119d for 1-8-stable.

Original commit message from f9996682b5739661c21548f0de3d4c4883c5119d:

Dialog: Before handling escape key presses, check if the default action has been prevented. Fixes #6966 - Pressing ESC on dialog when 2 dialogs are open closes both dialogs.

Changeset: abf97f73017794f93c52876221cf34018da5781c

Changed August 02, 2011 05:29PM UTC by scottgonzalez comment:9

milestone: 1.9 → 1.8.16

Changed August 02, 2011 05:31PM UTC by scottgonzalez comment:10

Thanks andreaspelme. The reason it wasn't included in 1-8-stable is because it didn't merge cleanly. Because some widgets are vastly different in 1-8-stable and master, if a non-blocker bug fix doesn't merge into 1-8-stable cleanly, we simply ignore it in favor of spending time working on master to get 1.9 out the door faster. We're always willing to accept patches to fix 1-8-stable from the community in these cases, so thanks for taking the time :-)