Pressing ESC on dialog when 2 dialogs are open closes both dialogs

[fracmak]

The correct behavior is to only close the active dialog.

[fracmak]

A pull request has been made that fixes this issue.

[fracmak]

pull request: ​https://github.com/jquery/jquery-ui/pull/117

[Scott González]

The ​new pull request can land if we can get core to fix the problem where native events don't carry properties over properly when bubbling (see pull request for details).

[Jay Merrifield]

Dialog: Before handling escape key presses, check if the default action has been prevented. Fixes #6966 - Pressing ESC on dialog when 2 dialogs are open closes both dialogs.

Changeset: f9996682b5739661c21548f0de3d4c4883c5119d

[Scott González]

#5365 is a duplicate of this ticket.

[Scott González]

#3539 is a duplicate of this ticket.

[andreaspelme]

This is not applied in the latest 1-8-stable tree. Why? It seems a pure bug fix and something that just bit me. The fix seems to be trivial to include in the 1-8-stable branch.

Here is a pull request for 1-8-stable with the patch backported: ​https://github.com/jquery/jquery-ui/pull/415

[Andreas Pelme]

Backport of f9996682b5739661c21548f0de3d4c4883c5119d for 1-8-stable.

Original commit message from f9996682b5739661c21548f0de3d4c4883c5119d: Dialog: Before handling escape key presses, check if the default action has been prevented. Fixes #6966 - Pressing ESC on dialog when 2 dialogs are open closes both dialogs.

Changeset: abf97f73017794f93c52876221cf34018da5781c

[Scott González]

Thanks andreaspelme. The reason it wasn't included in 1-8-stable is because it didn't merge cleanly. Because some widgets are vastly different in 1-8-stable and master, if a non-blocker bug fix doesn't merge into 1-8-stable cleanly, we simply ignore it in favor of spending time working on master to get 1.9 out the door faster. We're always willing to accept patches to fix 1-8-stable from the community in these cases, so thanks for taking the time :-)