#7043 closed bug (fixed)

Opened February 27, 2011 11:44AM UTC

Closed June 16, 2011 05:35PM UTC

Last modified June 16, 2011 05:36PM UTC

Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are needed

Reported by:	andrew1	Owned by:
Priority:	minor	Milestone:	1.8.14
Component:	ui.datepicker	Version:	1.8.10
Keywords:		Cc:
Blocked by:		Blocking:

Description

Firstly - great work!

Bug.

When selecting to use multiple months with the datepicker there appears to be an erroneous extra row of empty cells a the bottom effectively padding the bottom unnessarily.

kind regards

Andrew Blake - beginner level so sorry if off track

Attachments (0)

Change History (13)

Changed February 28, 2011 01:28PM UTC by scottgonzalez comment:1

description:	Firstly - great work! \ \ Bug. \ When selecting to use multiple months with the datepicker there appears to be an erroneous extra row of empty cells a the bottom effectively padding the bottom unnessarily. \ \ Enhancenment suggestion: \ \ I have hacked the source suitable for my purpose but in any case thought it could be useful enhancement to suggest. \ \ Useful to me to set popup on mouseenter rather than focus and to close on mouseleave \ \ and also I am using this to exclusively enter date so no need for blinking carat and have set text box style background and borders to none and hidden blinking caret. \ \ // hide blinking caret in text box \ $("#datepicker").bind("focus", function() { \ return false; \ }); \ \ kind regards \ Andrew Blake - beginner level so sorry if off track \ → Firstly - great work! \ \ Bug. \ When selecting to use multiple months with the datepicker there appears to be an erroneous extra row of empty cells a the bottom effectively padding the bottom unnessarily. \ \ kind regards \ Andrew Blake - beginner level so sorry if off track \
status:	new → open
summary:	ui datepicker extra row with muliple months. → Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are needed

Changed May 06, 2011 09:41PM UTC by kzys comment:2

https://github.com/jquery/jquery-ui/pull/223

Changed May 11, 2011 03:08PM UTC by Scott González comment:3

resolution:	→ fixed
status:	open → closed

Merge pull request #223 from kzys/trac-7043

Fixed #7043 - Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are neededf

Changeset: d3e21cf59ab6273f9b080c56afbc71fcf76139da

Changed May 11, 2011 03:10PM UTC by Kato Kazuyoshi comment:4

Datepicker: Fixed #7043 - Using multiple months always renders 6 rows of dates even if only 5 are needed.

(cherry picked from commit ac459ff7df4904cb8601d4efb95107177ecb40e0)

Changeset: 5e1032ec74feba976c91de275605174c87710a6a

Changed May 11, 2011 03:10PM UTC by scottgonzalez comment:5

milestone:	1.9 → 1.8.13

Changed May 12, 2011 09:09AM UTC by ThiefMaster comment:6

Uh.. depending on the months displayed the additional row is necessary - otherwise it might look bad since the single calendars would have different row counts.

While http://i.imgur.com/sPHe3.png is not a multi-month calendar it shows pretty much how it would look like.

Changed May 12, 2011 12:16PM UTC by scottgonzalez comment:7

resolution:	fixed
status:	closed → reopened

Thanks ThiefMaster, we were trying to figure out why it was hard-coded to 6 rows before, but the logic wasn't documented at all.

So a proper fix would render the number of months of the tallest month being rendered.

Changed May 12, 2011 12:17PM UTC by Scott González comment:8

resolution:	→ fixed
status:	reopened → closed

Revert "Datepicker: Fixed #7043 - Using multiple months always renders 6 rows of dates even if only 5 are needed."

This reverts commit ac459ff7df4904cb8601d4efb95107177ecb40e0.

Changeset: 1845015c09d527abde8095f8e2209f06d879a2b3

Changed May 12, 2011 12:18PM UTC by Scott González comment:9

Revert "Datepicker: Fixed #7043 - Using multiple months always renders 6 rows of dates even if only 5 are needed."

This reverts commit 5e1032ec74feba976c91de275605174c87710a6a.

Changeset: 804ba0a2df3a98db5929474daa3f664b7a3d5f29

Changed May 12, 2011 12:29PM UTC by scottgonzalez comment:10

milestone:	1.8.13 → 1.9
resolution:	fixed
status:	closed → reopened

Changed June 16, 2011 05:35PM UTC by Scott González comment:11

resolution:	→ fixed
status:	reopened → closed

Merge pull request #353 from kborchers/bug_7043

Datepicker: Calculate the max number of rows necessary when displaying months. Fixes #7043 - Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are needed

Changeset: fb210ae1ec16cefb1e4d4dfaf7d55499cac53ab8

Changed June 16, 2011 05:36PM UTC by scottgonzalez comment:12

milestone:	1.9 → 1.8.14

Changed June 16, 2011 05:36PM UTC by kborchers comment:13