#7103 closed enhancement (fixed)
Effects: Move effects to $.effects.effect[]
| Reported by: | Corey Frang | Owned by: | Corey Frang |
|---|---|---|---|
| Priority: | major | Milestone: | 1.9.0 |
| Component: | ui.effects.core | Version: | 1.8.10 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: | #7105 |
Description (last modified by )
Part 2 of http://bugs.jqueryui.com/ticket/7060#comment:4 as its own ticket:
In thinking about how to handle the BC shim for this API change, and other ways we might clean up the internal API - I thought we could move the actual effect implementation functions out of the $.effects[] and into $.effects.effect[] . It gives us a discreet namespace where we are sure that the function is an effect API function. Currently, other functions exist out on $.effects[] that aren't effects, allowing you to get interesting results for $("div").toggle("animateClass") - Letting that namespace hold utility functions, while pushing the actual effects into a new namespace could show some minor improvements.
Change History (6)
comment:2 Changed 12 years ago by
| Description: | modified (diff) |
|---|---|
| Priority: | minor → major |
comment:3 Changed 12 years ago by
| Owner: | set to Corey Frang |
|---|---|
| Status: | new → assigned |
comment:4 Changed 12 years ago by
| Blocking: | 7105 added |
|---|
comment:5 Changed 12 years ago by
| Summary: | Improving Internal Effects API - Part 2 → Effects: Move effects to $.effects.effect[] |
|---|
comment:5 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Effects: Moved effects to $.effects.effect[] and deprecated use of $.effects[]. Fixes #7103 - Effects: Move effects to $.effects.effect[].
Changeset: d64c9efda53f6e56feacf5f39940cd7719a2cb61
comment:6 Changed 12 years ago by
Datepicker: Updated to check for new or old style effects (see #7103).
Changeset: ac0cc2fac5c0be1be599e35524476718be1650e3
Moving
jQuery.sub()to another ticket per scotts request - leaving only$.effects.effect[]on this ticket: http://bugs.jqueryui.com/ticket/7105 contains the other part...