Opened 12 years ago
Closed 11 years ago
#7105 closed enhancement (wontfix)
Improving Internal Effects API - Part 3
| Reported by: | Corey Frang | Owned by: | Corey Frang |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.9.0 |
| Component: | ui.effects.core | Version: | 1.8.10 |
| Keywords: | Cc: | ||
| Blocked by: | #7103 | Blocking: |
Description
We could potentially leverage $.effects.$ = jQuery.sub() and extend its fn to serve up the setMode, save, restore, createWrapper, removeWrapper, and a few other helper functions that all take el as a first parameter. Each of the effect functions can then use $.effects.$( this ) and have all the helper functions available in a nice chain.
Got most of these changes in and you can look at the branch here: https://github.com/gnarf37/jquery-ui/compare/master...effects-sub
Change History (3)
comment:1 Changed 12 years ago by
| Owner: | set to Corey Frang |
|---|---|
| Status: | new → assigned |
comment:2 Changed 12 years ago by
| Blocked by: | 7103 added |
|---|
comment:3 Changed 11 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | assigned → closed |
$.sub is deprecated.
Note: See
TracTickets for help on using
tickets.
https://github.com/jquery/jquery-ui/pull/146 --- although right now it also includes http://bugs.jqueryui.com/ticket/7103