Opened 12 years ago
Closed 12 years ago
#7318 closed feature (fixed)
Add the queue functions to $.fn.effect()
| Reported by: | Corey Frang | Owned by: | Corey Frang |
|---|---|---|---|
| Priority: | major | Milestone: | 1.9.0 |
| Component: | ui.effects.core | Version: | 1.8.12 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description (last modified by )
Every effect in effects.effect returns this.queue(). We could DRY out the effects a bit while we are upgrading to 1.9 if we were to handle the "queue" issues in the main effects function.
Change History (4)
comment:1 Changed 12 years ago by
| Description: | modified (diff) |
|---|---|
| Owner: | set to Corey Frang |
| Priority: | minor → major |
| Status: | new → assigned |
comment:2 Changed 12 years ago by
| Type: | bug → feature |
|---|
comment:3 Changed 12 years ago by
comment:4 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Effects.*: Updating Effect Method API to avoid duplicating the queue call - Fixes #7318 - Add the queue functions to $.fn.effect()
Changeset: 1c1a3b1a361d90a73755fbd038b3cdfb0960c29f
Note: See
TracTickets for help on using
tickets.
Further amending this... All of the effects also are handing calling the complete callback - after putting the queue stuff into
$.fn.effectits now possible to wrap the complete function up with it and just pass onedoneargument for the effect to call when it finishes.