#7322 closed bug (fixed)

Opened May 04, 2011 10:10AM UTC

Closed May 12, 2011 03:29PM UTC

Last modified May 27, 2011 08:12PM UTC

Datepicker: Year selector disappears after setting an option in Firefox

Reported by:	ThiefMaster	Owned by:
Priority:	blocker	Milestone:	1.8.13
Component:	ui.datepicker	Version:	1.8.12
Keywords:		Cc:
Blocked by:		Blocking:

Description

1.8.12 introduced a bug breaking the year selector when setting an option after creating the datepicker.

Here's a minimal testcase: http://jsfiddle.net/ThiefMaster/XqT5H/1/

Attachments (0)

Change History (12)

Changed May 04, 2011 10:59AM UTC by utkarsh comment:1

On Windows 7, this bug exists on Firefox 4, but not on Chrome 11 or Opera.

Changed May 04, 2011 01:06PM UTC by scottgonzalez comment:2

priority:	minor → blocker
status:	new → open
summary:	Year selector disappears after setting an option → Datepicker: Year selector disappears after setting an option in Firefox

Changed May 05, 2011 05:23AM UTC by MatrixFrog comment:3

I'm not familiar with the JQuery UI code at all, but using the Firebug debugger, I found that this line (line 7822, near the top of _updateDatePicker) is when the dropdown actually disappears:

inst.dpDiv.empty().append(this._generateHTML(inst));

Also possibly worth noting is that if you set a breakpoint at that line, it will hit it twice, first from _setDateDatepicker and then again from _updateDatepicker. The second time is the one that makes the year dropdown go away.

Hopefully this is enough of a starting point to help someone fix this...

Changed May 05, 2011 06:03PM UTC by gplocke comment:4

_comment0:	Fix for this is provided with pull request: https://github.com/jquery/jquery-ui/pull/210 \ \ The original commit is here: https://github.com/gplocke/jquery-ui/commit/f3ee592c283bacdf9b0de50f23eca2cc038a2b42 → 1304618688909200

The issue seems to be happening only in Firefox, and is caused by the _updateDatepicker method being called twice. Removing the duplicate call seems to fix the problem.

Fix for this is provided with pull request: https://github.com/jquery/jquery-ui/pull/210

The original commit is here: https://github.com/gplocke/jquery-ui/commit/f3ee592c283bacdf9b0de50f23eca2cc038a2b42

Changed May 11, 2011 06:22PM UTC by Garrison Locke comment:5

resolution:	→ fixed
status:	open → closed

Datepicker: Removed duplicate call to _updateDatepicker when changing option in Firefox. Fixed #7322 - datepicker: Year would disappear when changing option.

Changeset: a645630ebaf02febb19a5c9e28f1e46401f07ed0

Changed May 11, 2011 06:23PM UTC by Garrison Locke comment:6

Datepicker: Removed duplicate call to _updateDatepicker when changing option in Firefox. Fixed #7322 - datepicker: Year would disappear when changing option.

(cherry picked from commit a645630ebaf02febb19a5c9e28f1e46401f07ed0)

Changeset: 3edda96f2a65a5c9544eab2b736dcd8b84edd8db

Changed May 11, 2011 06:23PM UTC by scottgonzalez comment:7

milestone:	1.9 → 1.8.13

Changed May 12, 2011 09:14AM UTC by ThiefMaster comment:8

_comment0:	Unfortunately this does '''not''' fully fix the issue. \ \ See http://jsfiddle.net/ThiefMaster/XqT5H/7/ for a case where it still bugs when setting an option right after creating the datepicker. → 1305191878318714

Unfortunately this does not fully fix the issue.

See http://jsfiddle.net/ThiefMaster/XqT5H/7/ for a case where it still bugs when setting an option right after creating the datepicker.

It does work when invoking the option "call" inside a zero-delay setTimeout callback though.. very odd.

Changed May 12, 2011 09:26AM UTC by gnarf comment:9

_comment0:	Confirming that http://jsfiddle.net/gnarf/XqT5H/8/ in '''Firefox''' is still broken → 1305192817891862
resolution:	fixed
status:	closed → reopened

Confirming that http://jsfiddle.net/gnarf/XqT5H/8/ in Firefox 4 is still broken

Changed May 12, 2011 03:29PM UTC by Andrew Powell comment:10

resolution:	→ fixed
status:	reopened → closed

Datepicker: removed conditional mozilla browser check block. Fixes #7322 - Year selector disappears after setting an option in Firefox

Changeset: a6227be2c09da2c698ee6d5251ac113b90585522

Changed May 12, 2011 03:29PM UTC by Andrew Powell comment:11