Sortable: Incorrect revert animation with axis: "y"

[pk_745]

Sortable bounces back in IE8,Chrome and Safari with revert true option. IE version: 8.0.6001.18702C0 Chrome: 10.0.648.151 Safari: 5.0.4(7533.20.27) Firefox(4.0) works perfectly.

Bug description: <ul> <li><img src="1.jpg" /></li> <li><img src="2.jpg" /></li> <li><img src="3.jpg" /></li> </ul>

Try following jQuery code: var options = {}; options.axis = "y"; options.containment = "parent"; options.cursor = "crosshair"; options.tolerance = "pointer"; options.revert = "true"; $('ul').sortable(options);

CSS: ul {list-style:none;}

• In IE8,Chrome and Safari this code doesn't work properly. While sorting, image bounces back and then realign(sort) to proper place.Code is very simple, developer can try by just copy and paste.

[tfs]

A very annoying bug with a very simple fix. I'm not using GitHub, so here's patch if anyone is interested:

ui/jquery.ui.sortable.js

@@ -285 +285 @@
                 //Regenerate the absolute position used for position checks
                 this.positionAbs = this._convertPositionTo("absolute");
 
-                //Set the helper position
-                if(!this.options.axis || this.options.axis != "y") this.helper[0].style.left = this.position.left+'px';
-                if(!this.options.axis || this.options.axis != "x") this.helper[0].style.top = this.position.top+'px';
+                //Set the helper position, use original position as defaults
+                var left = this.originalPosition.left+'px';
+                var top = this.originalPosition.top+'px';
 
+                if(!this.options.axis || this.options.axis != "y") left = this.position.left+'px';
+                if(!this.options.axis || this.options.axis != "x") top = this.position.top+'px';
+                
+                this.helper[0].style.left = left;
+                this.helper[0].style.top = top;
+
                 //Rearrange
                 for (var i = this.items.length - 1; i >= 0; i--) {

[mikesherov]

confirmed on latest in chrome: ​http://jsfiddle.net/KNDJY/

[tj.vantoll]

The only options that matter are axis: "y" & revert: true ​http://jsfiddle.net/tj_vantoll/fKTST/.

This occurs in the latest version of Chrome, Safari, and Opera as well as IE 7 - 10. Very interestingly it does not occur in Firefox.

[Scott González]

Sortable: Only animate along the specified axis when reverting. Fixes #7415 - Sortable: Incorrect revert animation with axis: 'y'.

Changeset: 054449e214449ec5578fe71bb67b9a670adac828