Draggable: _adjustOffsetFromHelper not reinvoked after "start" event is fired
|Reported by:||marcel.jackwerth||Owned by:|
While _cacheHelperProportions is reinvoked after the start-event, _adjustOffsetFromHelper is not. This leads to issues if you use right/bottom offsets (which depend on width/height) and you modify the helper (or it's content) during the start-event.
Here's the code of draggables mouseStart (removed irrelevant code for this problem)
//Cache the helper size this._cacheHelperProportions(); //Adjust the mouse offset relative to the helper if 'cursorAt' is supplied (o.cursorAt && this._adjustOffsetFromHelper(o.cursorAt)); //Recache the helper size this._cacheHelperProportions();
This could be fixed if we just add another _adjustOffsetFromHelper after the re-caching or are there any side-effects I am missing?
this._cacheHelperProportions(); (o.cursorAt && this._adjustOffsetFromHelper(o.cursorAt));
Change History (3)
comment:2 Changed 4 years ago by mikesherov
- Keywords haspatch added
- Status changed from new to open
- Summary changed from _adjustOffsetFromHelper not reinvoked after start-event to Draggable: _adjustOffsetFromHelper not reinvoked after "start" event is fired