#7564 closed bug (fixed)

Opened July 18, 2011 10:42PM UTC

Closed July 19, 2011 03:42PM UTC

Last modified July 19, 2011 03:42PM UTC

alignValue Global Scope

Reported by: be.davestein Owned by:
Priority: minor Milestone: 1.8.15
Component: ui.slider Version: 1.8.14
Keywords: Cc:
Blocked by: Blocking:
Description

_trimAlignValue is returning alignValue, but never uses a var statement within the function. Found it while reviewing my code in the DOM tab of Firebug.

Attachments (0)
Change History (4)

Changed July 19, 2011 10:15AM UTC by rdworth comment:1

resolution: → invalid
status: new → closed

step, valModStep and alignValue all share a single var statement. See lines 578-580

		var step = ( this.options.step > 0 ) ? this.options.step : 1,
			valModStep = (val - this._valueMin()) % step,
			alignValue = val - valModStep;

Changed July 19, 2011 03:40PM UTC by scottgonzalez comment:2

resolution: invalid
status: closed → reopened

This is definitely broken in 1.8.x.

Changed July 19, 2011 03:42PM UTC by Scott González comment:3

resolution: → fixed
status: reopened → closed

Slider: Fixed var statement. Fixes #7564 - alignValue Global Scope.

Changeset: 8d43fe7e3428e4fb4e5d9ca9e76a0d5078dfe708

Changed July 19, 2011 03:42PM UTC by scottgonzalez comment:4

milestone: 1.9 → 1.8.15