Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#7564 closed bug (fixed)

alignValue Global Scope

Reported by: be.davestein Owned by:
Priority: minor Milestone: 1.8.15
Component: ui.slider Version: 1.8.14
Keywords: Cc:
Blocked by: Blocking:

Description

_trimAlignValue is returning alignValue, but never uses a var statement within the function. Found it while reviewing my code in the DOM tab of Firebug.

Change History (4)

comment:1 Changed 5 years ago by rdworth

  • Resolution set to invalid
  • Status changed from new to closed

step, valModStep and alignValue all share a single var statement. See lines 578-580 

		var step = ( this.options.step > 0 ) ? this.options.step : 1,
			valModStep = (val - this._valueMin()) % step,
			alignValue = val - valModStep;

comment:2 Changed 5 years ago by scottgonzalez

  • Resolution invalid deleted
  • Status changed from closed to reopened

This is definitely broken in 1.8.x.

comment:3 Changed 5 years ago by Scott González

  • Resolution set to fixed
  • Status changed from reopened to closed

Slider: Fixed var statement. Fixes #7564 - alignValue Global Scope.

Changeset: 8d43fe7e3428e4fb4e5d9ca9e76a0d5078dfe708

comment:4 Changed 5 years ago by scottgonzalez

  • Milestone changed from 1.9 to 1.8.15
Note: See TracTickets for help on using tickets.