Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#7613 closed bug (fixed)

Incorrect UI keyCodes

Reported by: be.davestein Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.core Version: 1.8.14
Keywords: Cc:
Blocked by: Blocking:

Description

Apparently in Firefox Mac, COMMAND keyCode is 224. Everywhere else is 91 as the constants currently show in ui.core.

Change History (6)

comment:1 Changed 8 years ago by Scott González

Opera reports the keyCode as 17, perhaps we should define these keys and just rely on the event properties.

comment:2 Changed 8 years ago by Scott González

Opera and Firefox also don't differentiate between the left and right command keys.

comment:3 Changed 8 years ago by be.davestein

instead of e.keyCode === $.ui.keyCode.COMMAND, maybe the breaking change of $.ui.keyCode.isCommand( e.keyCode ) would be better for future proofing?

comment:4 Changed 8 years ago by Scott González

well, we should probably just use the event properties and fix event.metaKey

comment:5 Changed 8 years ago by Scott González

Resolution: fixed
Status: newclosed

Core: Removed modifier keys from key codes. Fixed #7613 - Incorrect UI keyCodes.

Changeset: 8dcb02d03598b75204227b5c187d8b6e8d33b03d

comment:6 Changed 8 years ago by Scott González

I "fixed" this by removing them.

Note: See TracTickets for help on using tickets.