Skip to main content

Search and Top Navigation

#7613 closed bug (fixed)

Opened August 05, 2011 08:32PM UTC

Closed February 12, 2012 05:29PM UTC

Last modified February 12, 2012 05:29PM UTC

Incorrect UI keyCodes

Reported by: be.davestein Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.core Version: 1.8.14
Keywords: Cc:
Blocked by: Blocking:

Apparently in Firefox Mac, COMMAND keyCode is 224. Everywhere else is 91 as the constants currently show in ui.core.

Attachments (0)
Change History (6)

Changed August 10, 2011 07:33PM UTC by scottgonzalez comment:1

Opera reports the keyCode as 17, perhaps we should define these keys and just rely on the event properties.

Changed August 10, 2011 07:38PM UTC by scottgonzalez comment:2

Opera and Firefox also don't differentiate between the left and right command keys.

Changed August 10, 2011 08:26PM UTC by be.davestein comment:3

instead of e.keyCode === $.ui.keyCode.COMMAND, maybe the breaking change of $.ui.keyCode.isCommand( e.keyCode ) would be better for future proofing?

Changed August 10, 2011 08:41PM UTC by scottgonzalez comment:4

well, we should probably just use the event properties and fix event.metaKey

Changed February 12, 2012 05:29PM UTC by Scott González comment:5

resolution: → fixed
status: newclosed

Core: Removed modifier keys from key codes. Fixed #7613 - Incorrect UI keyCodes.

Changeset: 8dcb02d03598b75204227b5c187d8b6e8d33b03d

Changed February 12, 2012 05:29PM UTC by scottgonzalez comment:6

I "fixed" this by removing them.