Skip to main content

Search and Top Navigation

#7795 closed enhancement (fixed)

Opened October 14, 2011 07:03PM UTC

Closed June 14, 2012 04:33PM UTC

Last modified June 14, 2012 04:34PM UTC

Widget: _on and _off

Reported by: gnarf Owned by:
Priority: minor Milestone: git
Component: ui.widget Version: git (not yet released)
Keywords: Cc:
Blocked by: Blocking:
Description

Should we adopt the naming from 1.7 core and start using

_on
instead of
_bind
and create a
_off
to unbind them?

We found a use for having a

_off
while we were doing a review of the Draggable interactions

Attachments (0)
Change History (6)

Changed February 27, 2012 03:41PM UTC by jzaefferer comment:1

What was the usecase for _off?

Changed February 27, 2012 03:43PM UTC by scottgonzalez comment:2

We dynamically bind and unbind for move and stop events.

Changed February 27, 2012 03:50PM UTC by jzaefferer comment:3

status: newopen

Should give that a try as part of interactions rewrite.

Changed June 13, 2012 12:01PM UTC by scottgonzalez comment:4

Renamed _bind() to _on() in 9608e981498846b3727cc4dad723a7fa7252fd86.

Changed June 14, 2012 04:33PM UTC by Scott González comment:5

resolution: → fixed
status: openclosed

Widget: Added _off() for removing event handlers. Fixes #7795 - Widget: _on and _off.

Changeset: ff39bed57a05ca060033187b8aecebafab357f78

Changed June 14, 2012 04:34PM UTC by scottgonzalez comment:6

milestone: 1.9git