Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#7795 closed enhancement (fixed)

Widget: _on and _off

Reported by: Corey Frang Owned by:
Priority: minor Milestone: git
Component: ui.widget Version: git (not yet released)
Keywords: Cc:
Blocked by: Blocking:

Description

Should we adopt the naming from 1.7 core and start using _on instead of _bind and create a _off to unbind them?

We found a use for having a _off while we were doing a review of the Draggable interactions

Change History (6)

comment:1 Changed 7 years ago by Jörn Zaefferer

What was the usecase for _off?

comment:2 Changed 7 years ago by Scott González

We dynamically bind and unbind for move and stop events.

comment:3 Changed 7 years ago by Jörn Zaefferer

Status: newopen

Should give that a try as part of interactions rewrite.

comment:4 Changed 7 years ago by Scott González

Renamed _bind() to _on() in 9608e981498846b3727cc4dad723a7fa7252fd86.

comment:5 Changed 7 years ago by Scott González

Resolution: fixed
Status: openclosed

Widget: Added _off() for removing event handlers. Fixes #7795 - Widget: _on and _off.

Changeset: ff39bed57a05ca060033187b8aecebafab357f78

comment:6 Changed 7 years ago by Scott González

Milestone: 1.9git
Note: See TracTickets for help on using tickets.