Dialog: default accessibility

[ezufelt]

Firefox 8.0 JAWS 13 Dialog demos 1.9pre

Problems

1. JAWS reports 'Basic dialog dialog. To navigate use tab. Application mode on.'. Using arrow keys I could not navigate, pressing tab once focus went to close button and application mode turned off.

2. Close button does not appear to receive focus when dialog appears.

3. Application mode should not be necessary for a non-modal dialog, we are not intending to sandbox users from rest of UI. If the intent is to sandbox users from rest of UI then application mode should be turned on using role="dialog" on wrapper for dialog and role="document" on direct descendant wrapper.

[ezufelt]

Another problem reported is that focus does not appear to return to the element that triggered the dialog when the dialog is dismissed.

[Scott González]

#8534 is a duplicate of this ticket.

[Jörn Zaefferer]

Testing agains the dialog branch here: ​https://github.com/jquery/jquery-ui/pull/794

"Another problem reported is that focus does not appear to return to the element that triggered the dialog when the dialog is dismissed." - this is fixed. We now have code in place that restores focus to the opener.

1. Looking at the default demo, this seems like it got worse. JAWS switches to application mode but unlike the modal demos, doesn't let me use cursor keys to read text elements.

2. This is still not the case and by design. If there's nothing inside the dialog's content to focus, the dialog itself is focused. The user can then tab to the close button.

3. Related to the issue with the first item. Need to figure out what to do here. Since we do the focus-trapping for both modal and non-modal dialogs, we probably want the sandboxing for non-modals as well.

[Jörn Zaefferer]

Telling JAWS to permanently stick to virtual cursor mode (Insert+Z twice) enables text navigation within the dialog. That shouldn't be necessary.

[Jörn Zaefferer]

Setting focus to a tabbable element inside the dialog fixed the issue with JAWS need reading anything for the default dialog demo. Contrary to what I wrote before, if there's nothing else, focus should go to the close button. Fixed in ​https://github.com/jquery/jquery-ui/commit/92b8a41164712e1bb2edc1a06afa37b9d9db0240

To test, see ​http://view.jqueryui.com/dialog/demos/dialog/default.html

[Jörn Zaefferer]

The dialog accessibility have landed in master, fixing the described issues.

Relevant commits: ​https://github.com/jquery/jquery-ui/commit/2a887e43213c4dbb21509b670cf5dc8ac2c67573 ​https://github.com/jquery/jquery-ui/commit/8ee8046c029354501bc6d1690b3ac84edf23efd7 ​https://github.com/jquery/jquery-ui/commit/83a9f219bf40ff834d660020bbfa7de550e48a0c