#7911 closed bug (wontfix)

Opened November 24, 2011 04:20PM UTC

Closed March 19, 2012 01:08PM UTC

Button: icon only button in dialog causes horizontal scrollbar in Opera

Reported by: PatrickM Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.button Version: 1.8.16
Keywords: Cc:
Blocked by: Blocking:
Description

From https://forum.jquery.com/topic/the-horizontal-slider-appears-in-the-demo-dialog-box-when-a-button-with-the-text-false-option-is-added

Attachments (0)
Change History (9)

Changed November 24, 2011 04:21PM UTC by rdworth comment:1

Reduced test case: http://jsbin.com/eqequp/edit#javascript,html,live

Changed November 24, 2011 04:21PM UTC by rdworth comment:2

This is caused by negative text-indent https://github.com/jquery/jquery-ui/blob/master/themes/base/jquery.ui.button.css#L19

Changed November 29, 2011 08:01PM UTC by Scott González comment:3

resolution: → fixed
status: new → closed

Button: Apply overflow: hidden in all browsers except IE 6,7 to avoid expanding the size of the button from negative text indent. Fixes #7911 - Button: icon only button in dialog causes horizontal scrollbar in Opera.

Changeset: a3a5c65d4dd9eb6be0e8a71d82c3ca86b38ed009

Changed November 29, 2011 08:02PM UTC by Scott González comment:4

Button: Apply overflow: hidden in all browsers except IE 6,7 to avoid expanding the size of the button from negative text indent. Fixes #7911 - Button: icon only button in dialog causes horizontal scrollbar in Opera.

(cherry picked from commit a3a5c65d4dd9eb6be0e8a71d82c3ca86b38ed009)

Changeset: 005709f432327ae672f7a613a8dca6200febe017

Changed November 29, 2011 08:03PM UTC by scottgonzalez comment:5

milestone: 1.9 → 1.8.18

Changed March 19, 2012 01:05PM UTC by Scott González comment:6

Revert "Button: Apply overflow: hidden in all browsers except IE 6,7 to avoid expanding the size of the button from negative text indent. Fixes #7911 - Button: icon only button in dialog causes horizontal scrollbar in Opera."

This reverts commit a3a5c65d4dd9eb6be0e8a71d82c3ca86b38ed009.

Changeset: 99fd8511ed4098a4cbf6c66999ef4df0bd8280be

Changed March 19, 2012 01:06PM UTC by Scott González comment:7

Revert "Button: Apply overflow: hidden in all browsers except IE 6,7 to avoid expanding the size of the button from negative text indent. Fixes #7911 - Button: icon only button in dialog causes horizontal scrollbar in Opera."

This reverts commit a3a5c65d4dd9eb6be0e8a71d82c3ca86b38ed009.

(cherry picked from commit 99fd8511ed4098a4cbf6c66999ef4df0bd8280be)

Changeset: 959e36bfc47ac8992e805aa34b736876e0e926cd

Changed March 19, 2012 01:07PM UTC by scottgonzalez comment:8

milestone: 1.8.18 → 1.9
resolution: fixed
status: closed → reopened

Reverted fix because it caused a more serious regression in Firefox: https://forum.jquery.com/topic/different-position-of-button-and-checkbox-in-toolbar

Changed March 19, 2012 01:08PM UTC by scottgonzalez comment:9

resolution: → wontfix
status: reopened → closed

The bug in Opera no longer exists with Opera 11.6.