Search and Top Navigation
#8165 closed bug (fixed)
Opened March 07, 2012 07:58AM UTC
Closed March 16, 2013 03:53PM UTC
Last modified April 17, 2013 03:47PM UTC
Draggable: Snapping large rectangles to small rectangles doesn't snap properly
| Reported by: | zmszaman | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.10.3 |
| Component: | ui.draggable | Version: | 1.8.18 |
| Keywords: | haspatch | Cc: | |
| Blocked by: | Blocking: |
Description
I notice that snap functionality works only on the corners of draggable items. When we have 2 draggable items on the page (one of them is much bigger) and we drag bigger item in direction of smaller item it doesn't snap. Smaller item works as expected. Here is link to test case: http://jsbin.com/ococaz - green rectangle snap to red rectangle but red rectangle doesn't snap to green rectangle.
Attachments (0)
Change History (9)
Changed October 11, 2012 02:49PM UTC by comment:1
| milestone: | 1.9.0 → 2.0.0 |
|---|
Changed October 28, 2012 07:44PM UTC by comment:2
| status: | new → open |
|---|---|
| summary: | Problem with snap option when dragging big rect → Draggable: Snapping doesn't take top/left into account properly |
Confirmed, but the problem is not as described. If you click and then drag the red rectangle downwards (even though it's constrained along the x axis) by the number of pixels that is the "top" css value of the green rectangle, then snapping works. It's as if the snap calculations don't take top/left css into account:
http://jsbin.com/ococaz/2/edit
Notice the difference between the two jsbin's.
Changed October 28, 2012 09:18PM UTC by comment:3
Sorry, but I think that you are wrong. Problem is that snap calculations are doing only from corners (omitting edge). If you drag red rectangle and one of it's corners is near green rectangle then it snap to it, but if every corners (of red rectangle) are more distant that snapTolerance then it doesn't snap.
Here is example: http://jsbin.com/ococaz/5/edit
If you drag red rectangle then light red rectangles must "touch" green rectangle to snap red rectangle to green rectangle. If you drag green rectangle then light green rectangles must "touch" red rectangle to snap green rectangle to red rectangle.
In order to snap red and green rectangle - you need to drag them to eachother. It doesn't matter if they will touch with edges or corners.
In the link below you can find the areas that shoud react the snapping:
Changed October 29, 2012 09:05AM UTC by comment:4
I send pull request on GitHub with patch for this issue.
Changed October 29, 2012 01:03PM UTC by comment:5
| keywords: | → haspatch |
|---|---|
| summary: | Draggable: Snapping doesn't take top/left into account properly → Draggable: Snapping large rectangles to small rectangles doesn't snap properly |
zmszaman, great! Thanks for the detective work!
Changed March 16, 2013 03:53PM UTC by comment:6
| resolution: | → fixed |
|---|---|
| status: | open → closed |
Draggable: modified snapping algorithm to use edges and corners. Fixed #8165 - Draggable: Snapping doesn't take top/left into account properly
Changeset: bd126a9c1cfcbc9d0fd370af25cfa0eab294fc4e
Changed March 16, 2013 03:53PM UTC by comment:7
| milestone: | 2.0.0 → 1.11.0 |
|---|
Changed April 17, 2013 03:46PM UTC by comment:8
Draggable: modified snapping algorithm to use edges and corners. Fixed #8165 - Draggable: Snapping doesn't take top/left into account properly(cherry picked from commit bd126a9c1cfcbc9d0fd370af25cfa0eab294fc4e)
Changeset: f74a9080562b9cedcae7030f3e4681b3ee0bfb14
Changed April 17, 2013 03:47PM UTC by comment:9
| milestone: | 1.11.0 → 1.10.3 |
|---|