Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#8267 closed bug (fixed)

dialog fadein broken since 1.9m4

Reported by: chadw Owned by:
Priority: minor Milestone: git
Component: ui.effects.* (individual effect) Version: git (not yet released)
Keywords: Cc:
Blocked by: Blocking:

Description

$.effects.effect.fade changed between 1.9m4 and 1.9m5. Since then, I am unable to get a dialog to fade in (fade out works). Perhaps a CSS tweak didn't make it to the dialog widget? The .show() is suspicious otherwise.

Changing jquery.effects.fade.js:

	el.show();
	el.animate({ 
		opacity: hide ? 0 : 1

To this:

//	el.show();
	el.animate({ 
		opacity: hide ? 'hide' : 'show'

Fixes it.

Change History (3)

comment:1 Changed 8 years ago by Scott González

Fade changed in 1eada2154910102e4c39d131a23af24ad0d92815 with no description of what the problem actually was, but looking at the test failure from the previous commit should provide enough insight.

comment:2 Changed 8 years ago by Scott González

Resolution: fixed
Status: newclosed

Effects (fade): Delegate hiding and showing to core. Fixes #8267 - dialog fadein broken since 1.9m4.

Changeset: d569b52838594c3e7e732d31dbf07dc2072edfdb

comment:3 Changed 8 years ago by Scott González

Milestone: 1.9git
Note: See TracTickets for help on using tickets.