Opened 8 years ago

Closed 8 years ago

#8343 closed bug (fixed)

_createButtons removes all elements with .ui-dialog-buttonpane class

Reported by: AlexW Owned by: AlexW
Priority: minor Milestone: 1.9.0
Component: ui.dialog Version: 1.8.20
Keywords: Cc:
Blocked by: Blocking:

Description

When trying to use the .ui-dialog-buttonpane class within a dialog it will be removed.

Suggested fix, Only search direct children. 

_createButtons: function(buttons) {
...
    self.uiDialog.find('>.ui-dialog-buttonpane').remove();
...
}

Change History (4)

comment:1 Changed 8 years ago by Scott González

Owner: set to AlexW
Status: new → pending

Why are you defining your own button pane?

comment:2 in reply to:  1 Changed 8 years ago by AlexW

Status: pending → new

Replying to scott.gonzalez:

Why are you defining your own button pane?

I have some tabs in a dialog. One of the tabs has a form with some buttons so I was just using the UI css to keep things consistent.

comment:3 Changed 8 years ago by Scott González

You really shouldn't use dialog-specific classes to theme tabs.

comment:4 Changed 8 years ago by Scott González

Resolution: → fixed
Status: new → closed

Dialog: Only create the button pane once and store a reference to it. Fixes #8343 - _createButtons removes all elements with .ui-dialog-buttonpane class.

Changeset: 286941ef8d325d6c0621eb29714792743871b1a3

Note: See TracTickets for help on using tickets.