Skip to main content

Search and Top Navigation

#8343 closed bug (fixed)

Opened May 22, 2012 11:17AM UTC

Closed May 22, 2012 12:29PM UTC

_createButtons removes all elements with .ui-dialog-buttonpane class

Reported by: AlexW Owned by: AlexW
Priority: minor Milestone: 1.9.0
Component: ui.dialog Version: 1.8.20
Keywords: Cc:
Blocked by: Blocking:

When trying to use the .ui-dialog-buttonpane class within a dialog it will be removed.

Suggested fix, Only search direct children.

_createButtons: function(buttons) {
Attachments (0)
Change History (4)

Changed May 22, 2012 11:51AM UTC by scottgonzalez comment:1

owner: → AlexW
status: newpending

Why are you defining your own button pane?

Changed May 22, 2012 11:55AM UTC by AlexW comment:2

status: pendingnew

Replying to [comment:1 scott.gonzalez]:

Why are you defining your own button pane?

I have some tabs in a dialog.

One of the tabs has a form with some buttons so I was just using the UI css to keep things consistent.

Changed May 22, 2012 12:29PM UTC by scottgonzalez comment:3

You really shouldn't use dialog-specific classes to theme tabs.

Changed May 22, 2012 12:29PM UTC by Scott González comment:4

resolution: → fixed
status: newclosed

Dialog: Only create the button pane once and store a reference to it. Fixes #8343 - _createButtons removes all elements with .ui-dialog-buttonpane class.

Changeset: 286941ef8d325d6c0621eb29714792743871b1a3