#8639 closed bug (fixed)

Opened October 09, 2012 10:12AM UTC

Closed October 09, 2012 12:41PM UTC

jQuery 1.9.0 dialog on a XHTML page is broken if buttons are defined

Reported by: at4u Owned by:
Priority: minor Milestone: 1.9.1
Component: ui.dialog Version: 1.9.0
Keywords: Cc:
Blocked by: Blocking:
Description

I just tried to use 1.9.0 on a website using XHTML 5. If I define a button to be shown on a dialog not all browsers but Firefox reports (translated):

Error: No corresponding tag. Expected: </button>.
Source: <div xmlns="http://www.w3.org/1999/xhtml"><button type='button'></div>

Furthermore no dialog is displayed.

Example "demos/dialog/modal-message.html" changed to "demos/dialog/modal-message.xhtml":

<?xml version='1.0' encoding='UTF-8' ?><!DOCTYPE html SYSTEM "about:legacy-compat">
<html xmlns='http://www.w3.org/1999/xhtml' xml:lang='en'>
<head>
	<title>jQuery UI Dialog - Modal message</title>
	<link rel="stylesheet" href="../../themes/base/jquery.ui.all.css" />
	<script src="../../jquery-1.8.2.js"></script>
	<script src="../../external/jquery.bgiframe-2.1.2.js"></script>
	<script src="../../ui/jquery.ui.core.js"></script>
	<script src="../../ui/jquery.ui.widget.js"></script>
	<script src="../../ui/jquery.ui.mouse.js"></script>
	<script src="../../ui/jquery.ui.button.js"></script>
	<script src="../../ui/jquery.ui.draggable.js"></script>
	<script src="../../ui/jquery.ui.position.js"></script>
	<script src="../../ui/jquery.ui.resizable.js"></script>
	<script src="../../ui/jquery.ui.dialog.js"></script>
	<link rel="stylesheet" href="../demos.css" />
	<script>
	$(function() {
		$( "#dialog-message" ).dialog({
			modal: true,
			buttons: {
				Ok: function() {
					$( this ).dialog( "close" );
				}
			}
		});
	});
	</script>
</head>
<body>

<div id="dialog-message" title="Download complete">
	<p>
		<span class="ui-icon ui-icon-circle-check" style="float:left; margin:0 7px 50px 0;"></span>
		Your files have downloaded successfully into the My Downloads folder.
	</p>
	<p>
		Currently using <b>36% of your storage space</b>.
	</p>
</div>

<p>Sed vel diam id libero <a href="http://example.com">rutrum convallis</a>. Donec aliquet leo vel magna. Phasellus rhoncus faucibus ante. Etiam bibendum, enim faucibus aliquet rhoncus, arcu felis ultricies neque, sit amet auctor elit eros a lectus.</p>

<div class="demo-description">
<p>Use a modal dialog to explicitly acknowledge information or an action before continuing their work.  Set the <code>modal</code> option to true, and specify a primary action (Ok) with the <code>buttons</code> option.</p>
</div>
</body>
</html>
Attachments (0)
Change History (1)

Changed October 09, 2012 12:41PM UTC by Richard D. Worth comment:1

resolution: → fixed
status: new → closed

Dialog: add required closing tag </button>. Fixes #8639 - jQuery 1.9.0 dialog on a XHTML page is broken if buttons are defined

Changeset: 1e6e4ce4dcd9ac885a7b4088898f61f4930e63a3