Opened 10 years ago

Closed 10 years ago

#8643 closed bug (fixed)

:focusable pseudo-selector does not find elements if parent has 0x0 dimension

Reported by: stefek99 Owned by: southerd
Priority: minor Milestone: 1.9.1
Component: ui.core Version: 1.9.0
Keywords: Cc:
Blocked by: Blocking:

Description

http://jsfiddle.net/7SBbu/

http://i273.photobucket.com/albums/jj226/stefek99/jQueryUI-0x0px.png

Just do not know whether this is bug or feature, just saying I found it peculiar :)

Change History (9)

comment:1 Changed 10 years ago by Scott González

Resolution: invalid
Status: newclosed

In the future please don't file tickets for things that you find peculiar. If it doesn't take up space, then it's not focusable.

comment:2 Changed 10 years ago by stefek99

Elements are visible, see revised: http://jsfiddle.net/stefek99/7SBbu/2/

(they weren't visible as document.write overriden the content)

Just do not know whether this is bug or feature, just saying I found it peculiar - it is up to core contributors to decide what is the expected bahaviour.

comment:3 Changed 10 years ago by Scott González

Resolution: invalid
Status: closedreopened

It's not really up to us, the elements are either focusable or they're not. Your fiddle shows that this is wrong.

comment:4 Changed 10 years ago by stefek99

http://jsfiddle.net/7SBbu/5/

Final revision of the test case.

In my browser visible hyperlinks are :focusable.

comment:5 Changed 10 years ago by Scott González

Except that visible is wrong because of the overflow. The fiddle has two visible links.

Last edited 10 years ago by Scott González (previous) (diff)

comment:6 Changed 10 years ago by mike.dormitorio

The first document.write() overwrites the page; hence, on the last line, the zero element no longer exists and size() returns 0.

comment:7 in reply to:  6 Changed 10 years ago by mike.dormitorio

Incorrect observation. Please disregard previous comment. :)

comment:8 Changed 10 years ago by southerd

Owner: set to southerd
Status: reopenedassigned

comment:9 Changed 10 years ago by Scott González

Resolution: fixed
Status: assignedclosed

Core: Update :focsable and :tabbable to handle parents with no height/width, but visible overflow. Fixes #8643 - :focusable pseudo-selector does not find elements if parent has 0x0 dimension.

Changeset: 86a958d3aa04a5928484d16b27a4d3eea39142e4

Note: See TracTickets for help on using tickets.