Skip to main content

Search and Top Navigation

#8643 closed bug (fixed)

Opened October 09, 2012 04:43PM UTC

Closed October 23, 2012 07:13PM UTC

:focusable pseudo-selector does not find elements if parent has 0x0 dimension

Reported by: stefek99 Owned by: southerd
Priority: minor Milestone: 1.9.1
Component: ui.core Version: 1.9.0
Keywords: Cc:
Blocked by: Blocking:
Description

http://jsfiddle.net/7SBbu/

[[Image(http://i273.photobucket.com/albums/jj226/stefek99/jQueryUI-0x0px.png)]]

Just do not know whether this is bug or feature, just saying I found it peculiar :)

Attachments (0)
Change History (9)

Changed October 09, 2012 05:10PM UTC by scottgonzalez comment:1

resolution: → invalid
status: newclosed

In the future please don't file tickets for things that you find peculiar. If it doesn't take up space, then it's not focusable.

Changed October 09, 2012 08:21PM UTC by stefek99 comment:2

Elements are visible, see revised: http://jsfiddle.net/stefek99/7SBbu/2/

''(they weren't visible as document.write overriden the content)''

Just do not know whether this is bug or feature, just saying I found it peculiar - it is up to core contributors to decide what is the expected bahaviour.

Changed October 09, 2012 08:49PM UTC by scottgonzalez comment:3

resolution: invalid
status: closedreopened

It's not really up to us, the elements are either focusable or they're not. Your fiddle shows that this is wrong.

Changed October 10, 2012 02:58PM UTC by stefek99 comment:4

http://jsfiddle.net/7SBbu/5/

Final revision of the test case.

In my browser visible hyperlinks are '':focusable''.

Changed October 10, 2012 03:00PM UTC by scottgonzalez comment:5

_comment0: Except that `:visible` is wrong because of the overflow.1349881345557745

Except that visible is wrong because of the overflow. The fiddle has two visible links.

Changed October 15, 2012 08:01AM UTC by mike.dormitorio comment:6

The first document.write() overwrites the page; hence, on the last line, the zero element no longer exists and size() returns 0.

Changed October 15, 2012 09:02AM UTC by mike.dormitorio comment:7

Incorrect observation. Please disregard previous comment. :)

Changed October 15, 2012 07:27PM UTC by southerd comment:8

owner: → southerd
status: reopenedassigned

Changed October 23, 2012 07:13PM UTC by Scott González comment:9

resolution: → fixed
status: assignedclosed

Core: Update :focsable and :tabbable to handle parents with no height/width, but visible overflow. Fixes #8643 - :focusable pseudo-selector does not find elements if parent has 0x0 dimension.

Changeset: 86a958d3aa04a5928484d16b27a4d3eea39142e4