Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8654 closed bug (fixed)

Spinner input has no background

Reported by: nicola7290 Owned by: nicola7290
Priority: minor Milestone: 1.9.1
Component: ui.spinner Version: 1.9.0
Keywords: Cc:
Blocked by: Blocking:

Description

When I create a Spinner Widget the background-color of the spinner is trasparent and this can create problem with the background-color of the page. I think it's a mistake.

span.ui-spinner {
    background: none repeat scroll 0 0 transparent;
}

Change History (6)

comment:1 Changed 7 years ago by Scott González

Component: CSS Frameworkui.spinner
Owner: set to nicola7290
Status: newpending

The rule is actually span.ui-spinner { background: none; } Regardless, I don't see how this would cause a problem, can you provide an example of where this is problematic?

comment:2 Changed 7 years ago by nicola7290

Status: pendingnew

Can you go at this link, please?

http://suite.sogiscuola.com/_librerie/_jquery-ui-1.9.0/index.html

Go at the bottom of the page, where I add the section "Spinner". I think that the spinner should have a default background-color (#ffffff ?) as normal input text.

Bye

comment:3 Changed 7 years ago by Scott González

Status: newopen

Yeah, that makes sense. I assume this was done because no other form controls are styled right now. I'll have to track down who added that rule and find out why it was done.

comment:4 Changed 7 years ago by Scott González

Well, this has been there since "the beginning": https://github.com/jquery/jquery-ui/commit/f7d8a1ba570fd620d65b377ebe806eac0b578328#diff-8

I'll talk to the rest of the team and see if anyone knows for sure why this was done.

comment:5 Changed 7 years ago by Jörn Zaefferer

Resolution: fixed
Status: openclosed

Spinner: Remove ui-state- classes from spinner, along with the background:none TR override. Fixes #8654 - Spinner background-color

Changeset: 112185ec8ddb7f0849fa40e7b1409e28153555f8

comment:6 Changed 7 years ago by Jörn Zaefferer

Summary: Spinner background-colorSpinner input has no background
Note: See TracTickets for help on using tickets.