Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8670 closed bug (fixed)

null reference when using effects

Reported by: 0cis32f Owned by: Corey Frang
Priority: blocker Milestone: 1.9.1
Component: ui.effects.core Version: 1.9.0
Keywords: regression Cc:
Blocked by: Blocking:

Description

In the 1.8 version i used to pass null for the options parameter in show method e.g.

$(el).show("blind", null, 600, null);

now it says options is null here :

effect.complete = callback || options.complete;

line of code 15606

probably missing an if not null check

Change History (6)

comment:1 Changed 7 years ago by ikarlik

Please address this as soon as possible. We have a lot of instances where we pass null for options into show() method.

$(el).show('drop', null, 500);

Changing them all to pass undefined or using show(options) overload shouldn't be a requirement.

$(el).show('drop', undefined, 500);
$(el).show({effect: 'drop', delay: 500});

It could be fixed with a change on one line from:

// catch (effect)
if ( options === undefined ) {
  options = {};
}

to this or equivalent:

// catch (effect)
if (options == null) {
  options = {};
}

comment:2 Changed 7 years ago by Scott González

Keywords: regression added
Milestone: 1.10.01.9.1
Priority: minorblocker
Status: newopen

comment:4 Changed 7 years ago by Corey Frang

Owner: set to Corey Frang
Status: openassigned

comment:5 Changed 7 years ago by Corey Frang

Resolution: fixed
Status: assignedclosed

Effects: Allow 'null' for options - Fixes #8670 - null reference when using effects - Closes gh-783

Changeset: 8b76684a92d7340175284bb369426f0164673b0a

comment:6 Changed 7 years ago by Corey Frang

Sorry, this one was my fault - Fix should land in 1.9.1

Note: See TracTickets for help on using tickets.