Skip to main content

Search and Top Navigation

#8670 closed bug (fixed)

Opened October 14, 2012 02:41PM UTC

Closed October 21, 2012 09:47PM UTC

Last modified October 21, 2012 09:50PM UTC

null reference when using effects

Reported by: 0cis32f Owned by: gnarf
Priority: blocker Milestone: 1.9.1
Component: ui.effects.core Version: 1.9.0
Keywords: regression Cc:
Blocked by: Blocking:

In the 1.8 version i used to pass null for the options parameter in show method e.g.

$(el).show("blind", null, 600, null);

now it says options is null here :

effect.complete = callback || options.complete;

line of code 15606

probably missing an if not null check

Attachments (0)
Change History (6)

Changed October 16, 2012 07:43PM UTC by ikarlik comment:1

Please address this as soon as possible. We have a lot of instances where we pass

for options into show() method.

$(el).show('drop', null, 500);

Changing them all to pass

or using
overload shouldn't be a requirement.

$(el).show('drop', undefined, 500);
$(el).show({effect: 'drop', delay: 500});

It could be fixed with a change on one line from:

// catch (effect)
if ( options === undefined ) {
  options = {};

to this or equivalent:

// catch (effect)
if (options == null) {
  options = {};

Changed October 16, 2012 07:46PM UTC by scottgonzalez comment:2

keywords: → regression
priority: minorblocker
status: newopen

Changed October 21, 2012 01:01AM UTC by maciejmrozinski comment:3

Changed October 21, 2012 09:46PM UTC by gnarf comment:4

owner: → gnarf
status: openassigned

Changed October 21, 2012 09:47PM UTC by Corey Frang comment:5

resolution: → fixed
status: assignedclosed

Effects: Allow 'null' for options - Fixes #8670 - null reference when using effects - Closes gh-783

Changeset: 8b76684a92d7340175284bb369426f0164673b0a

Changed October 21, 2012 09:50PM UTC by gnarf comment:6

Sorry, this one was my fault - Fix should land in 1.9.1