Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8687 closed bug (fixed)

.jshintrc files not copied to dist

Reported by: southerd Owned by: mikesherov
Priority: minor Milestone: 1.9.1
Component: [meta] ui.build Version: 1.9.0
Keywords: Cc:
Blocked by: Blocking:

Description

When building using grunt release, the .jshint files are not copied to the dist directory. This causes tests to fail when run against the build.

Change History (10)

comment:1 Changed 7 years ago by mikesherov

Owner: set to southerd
Status: newpending

Thanks for contributing! I'm not able to reproduce this issue. .jshintrc is not being copied to the dist directory, but how would this be causing the tests to fail? Can you be more specific in what you're doing when you say "run against the build"?

comment:2 Changed 7 years ago by Scott González

Status: pendingopen

mikesherov: Our QUnit tests run JSHint and they pull in the .jshintrc file using ajax. Of course, you can disable the JSHint test with ?nojshint=true, but we should probably have the default settings for tests working.

comment:3 Changed 7 years ago by mikesherov

Owner: changed from southerd to mikesherov
Status: openassigned

Got it. That's certainly interesting. Seems the path to the file just needs one more ../

Pull request coming shortly

comment:4 Changed 7 years ago by southerd

That won't work- .jshint will then no longer work when run from the source directory (./test). The dist directory I referred to is dist/jquery-ui-<%= version %>/ which contains the concatenated and minified files. The underlying problem is that minimatch, the globbing library grunt uses, doesn't copy hidden . files in the 0.3.x grunt releases- Ben Alman will be fixing this in 0.4, but another solution might be needed now.

comment:5 Changed 7 years ago by mikesherov

Yup, you're right. I just wrapped my head around it. you're talking about the test suite in dist. Looking for a solution now.

comment:6 Changed 7 years ago by southerd

To save you a bit of time, I poked at it a bit during the Summit.

Changing the copy line from "ui/*" to "ui/{.,}*" does not seem to work.

Adding the line "ui/.jshintrc" puts the .jshint in the wrong location (in jquery-ui-{version}/ instead of jquery-ui-{version}/ui)

I regressed to hand-copying after a build- didn't have time to shave yaks at the summit :(

comment:8 Changed 7 years ago by mikesherov

southerd, thanks for your help!

comment:9 Changed 7 years ago by Mike Sherov

Resolution: fixed
Status: assignedclosed

Build: Include ui/.jshintrc. Fixes #8687 - .jshintrc files not copied to dist.

Changeset: 390510c7059d98d68cfe082530051c476ee08be4

comment:10 Changed 7 years ago by Scott González

Milestone: 1.10.01.9.1

The .jshintrc files aren't really needed in the distributed files, so we only copied the one that's required for the QUnit tests.

Note: See TracTickets for help on using tickets.