Opened 10 years ago
Closed 10 years ago
#8694 closed bug (fixed)
Accordion: 1.9 - active: null allows panels to be collapsible.
Reported by: | martinkoutny | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.9.1 |
Component: | ui.accordion | Version: | 1.9.0 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
In jQuery UI 1.8, when I initialize Accordion with option active: false it show Accordion with all collapsed panels. After open first panel, user can swith them, but can't close all of them back - one panel is still open.
In jQuery UI 1.9 with same options. It will show accordion with already opened first panel. At API documentation of active option is "This requires the collapsible option to be true.". But when I enable it, accordion starts fine (with all panels collapsed) but when user open one, he can also close it.
I found solution of this different behavior: In 1.9 use option active: null to get same result like use active: false in 1.8.
Is this usage alright? Or it's a bug?
Change History (7)
comment:1 Changed 10 years ago by
Summary: | 1.9 Accordion - active and collapsible options → 1.9 Accordion - active: null allows panels to be collapsible. |
---|
comment:2 Changed 10 years ago by
Status: | new → open |
---|
comment:3 Changed 10 years ago by
Summary: | 1.9 Accordion - active: null allows panels to be collapsible. → Accordion: 1.9 - active: null allows panels to be collapsible. |
---|
Pull request to fix this active: null problem https://github.com/jquery/jquery-ui/pull/774
comment:4 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | open → closed |
Accordion: handle active: null. Fixes #8694: 1.9 Accordion - active: null allows panels to be collapsible.
Changeset: c2802d7aa05e6dc7731806a35d9f0057405a22c7
comment:5 Changed 10 years ago by
Milestone: | 1.10.0 → 1.9.1 |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
This actually broke back compat.
comment:7 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Fixed in eb392b30359e334a1777ed3a8bc1237ce09528a5.
active: null should not allow all panels to be collapsed. The only way to have collapsed panels is to use collapsible: true.