Opened 7 years ago

Closed 7 years ago

#8696 closed bug (fixed)

Multiple collapsible Accordions won't work together

Reported by: dittodhole Owned by:
Priority: blocker Milestone: 1.9.1
Component: ui.accordion Version: 1.9.0
Keywords: regression Cc:
Blocked by: Blocking:

Description

Please see fiddle: http://jsfiddle.net/dittodhole/3j9r4/

Basically I have multiple collapsible Accordions on one page. If I open (click) one, it gets rendered "under" (z-index) the next Accordion.

Change History (5)

comment:1 Changed 7 years ago by dittodhole

updated example fiddle to new h3-tags: http://jsfiddle.net/dittodhole/3j9r4/1/ (still not working as expected)

comment:2 Changed 7 years ago by dittodhole

see example (http://jsfiddle.net/dittodhole/3j9r4/2/) for working example with 1.8.4

comment:3 Changed 7 years ago by Scott González

Component: ui.coreui.accordion
Keywords: regression added
Milestone: 1.10.01.9.1
Priority: minorblocker
Status: newopen

An actually reduced test case: http://jsfiddle.net/3j9r4/3/

comment:4 Changed 7 years ago by maciejmrozinski

even more reduced test case: http://jsfiddle.net/3j9r4/4/ Two accordion it's not the case here. Accordion doesn't recalculate it's height after collapsing or expanding. When we expand it, the main accordion div have the same height as before expanding and this is resulting in not pushing text down. If we remove height style on main accordion div, all positioning becomes valid.

Do we need to set height property on the accordion? We didn't do that in 1.8 and i think it's not necessary for accordion to work well.

This is my pull request that resolves the problem by eliminating operations on accordion height property: https://github.com/jquery/jquery-ui/pull/785

comment:5 Changed 7 years ago by Maciej Mroziński

Resolution: fixed
Status: openclosed

Accordion: Remove code that sets accordion height. Fixed #8696 - Multiple collapsible Accordions won't work together.

Changeset: f4b3cd527116b25d4d6f44c2df0f2c472b961e6a

Note: See TracTickets for help on using tickets.