Opened 10 years ago
Closed 10 years ago
#8696 closed bug (fixed)
Multiple collapsible Accordions won't work together
Reported by: | dittodhole | Owned by: | |
---|---|---|---|
Priority: | blocker | Milestone: | 1.9.1 |
Component: | ui.accordion | Version: | 1.9.0 |
Keywords: | regression | Cc: | |
Blocked by: | Blocking: |
Description
Please see fiddle: http://jsfiddle.net/dittodhole/3j9r4/
Basically I have multiple collapsible Accordions on one page. If I open (click) one, it gets rendered "under" (z-index) the next Accordion.
Change History (5)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
see example (http://jsfiddle.net/dittodhole/3j9r4/2/) for working example with 1.8.4
comment:3 Changed 10 years ago by
Component: | ui.core → ui.accordion |
---|---|
Keywords: | regression added |
Milestone: | 1.10.0 → 1.9.1 |
Priority: | minor → blocker |
Status: | new → open |
An actually reduced test case: http://jsfiddle.net/3j9r4/3/
comment:4 Changed 10 years ago by
even more reduced test case: http://jsfiddle.net/3j9r4/4/ Two accordion it's not the case here. Accordion doesn't recalculate it's height after collapsing or expanding. When we expand it, the main accordion div have the same height as before expanding and this is resulting in not pushing text down. If we remove height style on main accordion div, all positioning becomes valid.
Do we need to set height property on the accordion? We didn't do that in 1.8 and i think it's not necessary for accordion to work well.
This is my pull request that resolves the problem by eliminating operations on accordion height property: https://github.com/jquery/jquery-ui/pull/785
comment:5 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | open → closed |
Accordion: Remove code that sets accordion height. Fixed #8696 - Multiple collapsible Accordions won't work together.
Changeset: f4b3cd527116b25d4d6f44c2df0f2c472b961e6a
updated example fiddle to new h3-tags: http://jsfiddle.net/dittodhole/3j9r4/1/ (still not working as expected)