Resizable: Complex markup for handles

[MatteS75]

Creating a handle with an inner element renders the resize handle useless.

1. Create a resizable div with an inner div with the handle classes setup
2. Add another div inside the handle div
3. Initialize the resizable

Now the resizable handle does not work. Removing the inner div, and it does work.

jsFiddle: ​http://jsfiddle.net/MatteS75/3dwVp/15/

[MatteS75]

Possible workaround:

$.widget("ui.myresizable", $.ui.resizable, {

	_mouseCapture: function (event) {
		var handle = false;
		for (var i in this.handles) {
			if ($(this.handles[i])[0] == event.target || $(this.handles[i]).has(event.target)) {
				handle = true;
			}
		}

		return !this.options.disabled && handle;
	}

});

[Scott González]

What is your use case that makes this necessary?

[MatteS75]

Replying to scott.gonzalez:

What is your use case that makes this necessary?

For me, I need it to style the handle. I know its not always the best solution to add divs just for styling, but in this case I need to make a css based triangle using the common css trick: ​http://css-tricks.com/snippets/css/css-triangle/

I have fixed the problem in our jquery ui code directly, but would rather this worked out of the box ofcourse.

I could help fix it, but im a bit new to contributing to js oss projects. I guess ill have to dive into the jquery ui code with tests and all if so.

Anyway, my fix looks like this:

 	_mouseCapture: function(event) {
 		var handle = false;
 		for (var i in this.handles) {
-			if ($(this.handles[i])[0] == event.target) {
+			if ($(this.handles[i])[0] == event.target || $(this.handles[i]).has(event.target)) {
 				handle = true;
 			}
 		}

[Scott González]

You can build any CSS design using a single element, so I don't see why you need nested elements for this: ​http://jsfiddle.net/3dwVp/17/

[MatteS75]

Replying to scott.gonzalez:

You can build any CSS design using a single element, so I don't see why you need nested elements for this: ​http://jsfiddle.net/3dwVp/17/

Yes, for a single element that is nice.

However, our design requires something like this: ​http://jsfiddle.net/3dwVp/18/ If I can make it like that without an inner div itd make my day.

[MatteS75]

By the way, I have forked the repo and am investigating how to best write tests for this at this point.

[MatteS75]

Ok, I think I got it working, and the fix was a little different and better than my first suggestion I think. Here is the pull request:

​https://github.com/jquery/jquery-ui/pull/804

[MatteS75]

If this pull request is accepted, id gladly fix ​http://bugs.jqueryui.com/ticket/8757 aswell. Or repost a new ticket, if that thing still fails that is.

[MatteS75]

A new pull request. I made a branching mistake with the first one. As said, im new to this =)

​https://github.com/jquery/jquery-ui/pull/807

[Mathias Stenbom]

Resizable: Made handles work with complex markup. Fixes #8756 - Resizable: Complex markup for handles.

Changeset: 0bff32a2b1c2273e46dc0f70bc1058ad304ebcc5

[MatteS75]

New pull request!

​https://github.com/jquery/jquery-ui/pull/810