Skip to main content

Search and Top Navigation

#8758 closed bug (fixed)

Opened October 31, 2012 02:00PM UTC

Closed November 09, 2012 06:07PM UTC

Last modified November 13, 2012 04:01PM UTC

Tooltip: Tooltip is shown, but not hidden if element has class="ui-state-disabled"

Reported by: Mamen Owned by:
Priority: minor Milestone: 1.9.2
Component: ui.tooltip Version: 1.9.1
Keywords: Cc:
Blocked by: Blocking:
Description

http://jsbin.com/opugon/1/edit

Tooltip is stuck since it opens, but never closes on hover.

Attachments (0)
Change History (14)

Changed October 31, 2012 02:04PM UTC by scottgonzalez comment:1

status: newopen

This is probably from the disabled check in ._on(). I really wish there was a clean way to opt out of that.

Changed October 31, 2012 02:24PM UTC by Mamen comment:2

I would assume that the class would prevent it from showing in the first place.

Changed October 31, 2012 02:55PM UTC by jzaefferer comment:3

That would work already when binding the tooltip directly to the element: http://jsbin.com/opugon/2/ Though that way you end up with the native tooltip.

For the delegated tooltip, _on would have to check for the ui-state-disabled class on the event.target or one of its parents.

Changed November 02, 2012 01:09PM UTC by scottgonzalez comment:4

Related to #8769.

Changed November 05, 2012 04:53PM UTC by scottgonzalez comment:5

Replying to [comment:2 Mamen]:

I would assume that the class would prevent it from showing in the first place.

Why would you assume that? If you want to disable the tooltip, then disable the tooltip, or change the items option to not match .ui-state-disabled.

Changed November 05, 2012 04:55PM UTC by jzaefferer comment:6

If you want to actually disable the input, you should set the disabled-attribute. That would also disable the tooltip.

Changed November 05, 2012 04:58PM UTC by jzaefferer comment:7

Once #8769 is resolved, tooltip needs to turn off the disabled check for the handles bound in _open.

Changed November 05, 2012 07:16PM UTC by Mamen comment:8

Replying to [comment:5 scott.gonzalez]:

Replying to [comment:2 Mamen]: > I would assume that the class would prevent it from showing in the first place. Why would you assume that? If you want to disable the tooltip, then disable the tooltip, or change the items option to not match .ui-state-disabled.

I assume that the same code that blocked the tooltip from hiding also would block it from showing. However I do not except the widget to work this way. Showing a tooltip on a disabled element could be an important way of describing why the element is disabled.

Changed November 05, 2012 07:31PM UTC by scottgonzalez comment:9

Thanks for clarifying. That makes more sense.

Changed November 09, 2012 10:54AM UTC by jzaefferer comment:10

blockedby: → 8769

Changed November 09, 2012 05:53PM UTC by scottgonzalez comment:11

blockedby: 8769

Changed November 09, 2012 06:07PM UTC by Scott González comment:12

resolution: → fixed
status: openclosed

Tooltip: Ignore disabled checks when closing. Fixes #8758 - Tooltip: Tooltip is shown, but not hidden if element has class=ui-state-disabled.

Changeset: 498aadf644ddca86de838dc2001267ded972df2c

Changed November 13, 2012 03:57PM UTC by Scott González comment:13

Tooltip: Ignore disabled checks when closing. Fixes #8758 - Tooltip: Tooltip is shown, but not hidden if element has class=ui-state-disabled.

(cherry picked from commit 498aadf644ddca86de838dc2001267ded972df2c)

Changeset: b5cf5b6ad88321eb17cd4a061430db9057eea96f

Changed November 13, 2012 04:01PM UTC by scottgonzalez comment:14

milestone: 1.10.01.9.2