Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8758 closed bug (fixed)

Tooltip: Tooltip is shown, but not hidden if element has class="ui-state-disabled"

Reported by: Mamen Owned by:
Priority: minor Milestone: 1.9.2
Component: ui.tooltip Version: 1.9.1
Keywords: Cc:
Blocked by: Blocking:

Description

http://jsbin.com/opugon/1/edit

Tooltip is stuck since it opens, but never closes on hover.

Change History (14)

comment:1 Changed 7 years ago by Scott González

Status: newopen

This is probably from the disabled check in ._on(). I really wish there was a clean way to opt out of that.

comment:2 Changed 7 years ago by Mamen

I would assume that the class would prevent it from showing in the first place.

comment:3 Changed 7 years ago by Jörn Zaefferer

That would work already when binding the tooltip directly to the element: http://jsbin.com/opugon/2/ Though that way you end up with the native tooltip.

For the delegated tooltip, _on would have to check for the ui-state-disabled class on the event.target or one of its parents.

comment:4 Changed 7 years ago by Scott González

Related to #8769.

comment:5 in reply to:  2 ; Changed 7 years ago by Scott González

Replying to Mamen:

I would assume that the class would prevent it from showing in the first place.

Why would you assume that? If you want to disable the tooltip, then disable the tooltip, or change the items option to not match .ui-state-disabled.

comment:6 Changed 7 years ago by Jörn Zaefferer

If you want to actually disable the input, you should set the disabled-attribute. That would also disable the tooltip.

comment:7 Changed 7 years ago by Jörn Zaefferer

Once #8769 is resolved, tooltip needs to turn off the disabled check for the handles bound in _open.

comment:8 in reply to:  5 Changed 7 years ago by Mamen

Replying to scott.gonzalez:

Replying to Mamen:

I would assume that the class would prevent it from showing in the first place.

Why would you assume that? If you want to disable the tooltip, then disable the tooltip, or change the items option to not match .ui-state-disabled.

I assume that the same code that blocked the tooltip from hiding also would block it from showing. However I do not except the widget to work this way. Showing a tooltip on a disabled element could be an important way of describing why the element is disabled.

comment:9 Changed 7 years ago by Scott González

Thanks for clarifying. That makes more sense.

comment:10 Changed 7 years ago by Jörn Zaefferer

Blocked by: 8769 added

comment:11 Changed 7 years ago by Scott González

Blocked by: 8769 removed

comment:12 Changed 7 years ago by Scott González

Resolution: fixed
Status: openclosed

Tooltip: Ignore disabled checks when closing. Fixes #8758 - Tooltip: Tooltip is shown, but not hidden if element has class=ui-state-disabled.

Changeset: 498aadf644ddca86de838dc2001267ded972df2c

comment:13 Changed 7 years ago by Scott González

Tooltip: Ignore disabled checks when closing. Fixes #8758 - Tooltip: Tooltip is shown, but not hidden if element has class=ui-state-disabled. (cherry picked from commit 498aadf644ddca86de838dc2001267ded972df2c)

Changeset: b5cf5b6ad88321eb17cd4a061430db9057eea96f

comment:14 Changed 7 years ago by Scott González

Milestone: 1.10.01.9.2
Note: See TracTickets for help on using tickets.