Opened 7 years ago

Closed 7 years ago

#8772 closed bug (fixed)

Slider: Incorrect UI state when disabled at init

Reported by: samycookie Owned by:
Priority: minor Milestone: 1.10.0
Component: ui.slider Version: 1.8.20
Keywords: haspatch Cc:
Blocked by: Blocking:

Description

The slider widget have not the good UI design when disabled at creation.

see http://jsfiddle.net/mCFv5/7/

Change History (6)

comment:2 Changed 7 years ago by tj.vantoll

Keywords: haspatch added
Status: newopen
Summary: Wrong slider UI state when disabled at initSlider: Incorrect UI state when disabled at init

Thanks for taking the time to contribute to the jQuery UI project. The issue here is that when the slider is created as disabled it is not getting the "ui-state-disabled" class. If you would like to submit your fix please create a branch on your fork and submit a pull request.

Please include a unit test showing that before the slider did not have the appropriate class upon initialization and after your fix is applied it does.

comment:3 Changed 7 years ago by samycookie

comment:4 Changed 7 years ago by Scott González

@samycookie Thanks, can you send a pull request?

comment:5 Changed 7 years ago by samycookie

I updated the test case, and pull requested my branch. https://github.com/jquery/jquery-ui/pull/824/

comment:6 Changed 7 years ago by Samuel Bovée

Resolution: fixed
Status: openclosed

Slider: factorize code with Widget method call. Fixed #8772 - Wrong slider UI state when disabled at init

Changeset: cb748b4a6f32aa5748d6777e7871c96f70ad2207

Note: See TracTickets for help on using tickets.