#8813 closed bug (fixed)

Opened November 14, 2012 05:39PM UTC

Closed November 14, 2012 07:59PM UTC

Last modified November 14, 2012 07:59PM UTC

Tabs: select event not triggering when collapsible:true

Reported by: abacada Owned by:
Priority: minor Milestone: 1.9.2
Component: ui.tabs Version: 1.9.1
Keywords: regression Cc:
Blocked by: Blocking:
Description

Using 1.8.9: http://jsfiddle.net/2uzxU/1/ - OK

Using 1.9.1: http://jsfiddle.net/2uzxU/2/ - NOT OK

I expect the alert to be executed when clicking once in the first tab using the old API.

Attachments (0)
Change History (9)

Changed November 14, 2012 05:44PM UTC by scottgonzalez comment:1

keywords: → regression
status: new → open
summary: select option not triggering when collapsible:true → Tabs: select event not triggering when collapsible:true

Changed November 14, 2012 06:21PM UTC by drew.waddell comment:2

This is not a bug, updated jsFiddle: http://jsfiddle.net/2uzxU/3/

Upgrade Guide: http://jqueryui.com/upgrade-guide/1.9/#deprecated-select-event-renamed-to-beforeactivate

Changed November 14, 2012 06:38PM UTC by scottgonzalez comment:3

@drew.waddell: This is pretty clearly a regression. Just because it's deprecated doesn't mean that we can change the behavior of it.

Changed November 14, 2012 07:15PM UTC by drew.waddell comment:4

True, in my eyes though deprecated pretty much means not supported. My feeling is that the effort of correcting something in a deprecated feature always outweighs waiting until the deprecated feature is gone.

Changed November 14, 2012 07:19PM UTC by scottgonzalez comment:5

It's important for us to get users off of 1.8, even if they're using deprecated APIs.

Changed November 14, 2012 07:53PM UTC by abacada comment:6

Ticket opened based on "If you find a regression from the 1.8 API, please report it in the bug tracker. Even though the 1.8 API is deprecated, it's important for 1.9 releases not to regress so that users are encouraged to upgrade even if they're not ready to use the new APIs."

http://jqueryui.com/upgrade-guide/1.9/#preparing-for-jquery-ui-1-10

I am not ready to update yet but I want to keep 1.9 to start changing softly. I hope you understand that I need 1.9 working to start changing for 1.10. Thanks.

Changed November 14, 2012 07:58PM UTC by scottgonzalez comment:7

@abacada Yes, that's very important to me. It's extremely difficult for users to tell if they're ready for 1.10.0 without being able to seamlessly upgrade to 1.9.x. I'll have this fixed very soon and it'll be in the 1.9.2 release.

Changed November 14, 2012 07:59PM UTC by Scott González comment:8

resolution: → fixed
status: open → closed

Tabs: Trigger the select event when collapsing. Fixes #8813 - Tabs: select event not triggering when collapsible:true.

Changeset: d7ee9569e18ac46ad3f0a23e790e48d3ee5a44c4

Changed November 14, 2012 07:59PM UTC by scottgonzalez comment:9

milestone: 1.10.0 → 1.9.2