Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8813 closed bug (fixed)

Tabs: select event not triggering when collapsible:true

Reported by: abacada Owned by:
Priority: minor Milestone: 1.9.2
Component: ui.tabs Version: 1.9.1
Keywords: regression Cc:
Blocked by: Blocking:

Description

Using 1.8.9: http://jsfiddle.net/2uzxU/1/ - OK

Using 1.9.1: http://jsfiddle.net/2uzxU/2/ - NOT OK

I expect the alert to be executed when clicking once in the first tab using the old API.

Change History (9)

comment:1 Changed 7 years ago by Scott González

Keywords: regression added
Status: newopen
Summary: select option not triggering when collapsible:trueTabs: select event not triggering when collapsible:true

comment:3 Changed 7 years ago by Scott González

@drew.waddell: This is pretty clearly a regression. Just because it's deprecated doesn't mean that we can change the behavior of it.

comment:4 Changed 7 years ago by drew.waddell

True, in my eyes though deprecated pretty much means not supported. My feeling is that the effort of correcting something in a deprecated feature always outweighs waiting until the deprecated feature is gone.

comment:5 Changed 7 years ago by Scott González

It's important for us to get users off of 1.8, even if they're using deprecated APIs.

comment:6 Changed 7 years ago by abacada

Ticket opened based on "If you find a regression from the 1.8 API, please report it in the bug tracker. Even though the 1.8 API is deprecated, it's important for 1.9 releases not to regress so that users are encouraged to upgrade even if they're not ready to use the new APIs."

http://jqueryui.com/upgrade-guide/1.9/#preparing-for-jquery-ui-1-10

I am not ready to update yet but I want to keep 1.9 to start changing softly. I hope you understand that I need 1.9 working to start changing for 1.10. Thanks.

comment:7 Changed 7 years ago by Scott González

@abacada Yes, that's very important to me. It's extremely difficult for users to tell if they're ready for 1.10.0 without being able to seamlessly upgrade to 1.9.x. I'll have this fixed very soon and it'll be in the 1.9.2 release.

comment:8 Changed 7 years ago by Scott González

Resolution: fixed
Status: openclosed

Tabs: Trigger the select event when collapsing. Fixes #8813 - Tabs: select event not triggering when collapsible:true.

Changeset: d7ee9569e18ac46ad3f0a23e790e48d3ee5a44c4

comment:9 Changed 7 years ago by Scott González

Milestone: 1.10.01.9.2
Note: See TracTickets for help on using tickets.