Skip to main content

Search and Top Navigation

#8838 closed bug (fixed)

Opened November 21, 2012 05:33AM UTC

Closed November 26, 2012 09:30AM UTC

Dialog: Close icon does not work in dialog larger than the window in IE

Reported by: clifforama Owned by:
Priority: minor Milestone: 1.10.0
Component: ui.dialog Version: 1.9.1
Keywords: regression Cc:
Blocked by: Blocking:
Description

After opening a dialog that doesn't fit within the window, clicking the close icon won't close the dialog. Instead, it moves the dialog to the top of the viewport. Only when the dialog is top-aligned to the viewport will a subsequent click close the dialog.

Problem occurs with jQuery UI 1.9.1, but does *NOT* occur with jQuery UI 1.9.0.

Reproducible in:

  • Internet Explorer 9
  • Internet Explorer 9 in IE8 Browser Mode
  • Internet Explorer 9 in IE7 Browser Mode

Not reproducible in:

  • Firefox 16.0.2
  • Chrome 23.0.1271.64 m
  • Safari 5.1.7 (7534.57.2)

Test case:

1. http://jsfiddle.net/zcYGE/10/

2. reduce height of results panel to as small as possible

3. click "Open dialog" link to open the dialog

4. scroll results panel until dialog's close icon is in view

5. click close icon (this moves dialog to top of results panel instead of closing dialog)

6. click close icon again to actually close dialog

Attachments (0)
Change History (3)

Changed November 21, 2012 02:50PM UTC by tj.vantoll comment:1

keywords: → regression
status: newopen
summary: In dialog that's larger than window, close icon only works when dialog is top-aligned to viewportDialog: Close icon does not work in dialog larger than the window in IE

Confirmed. The issue also occurs in IE10 and is not present in 1.9.0.

Changed November 22, 2012 09:54AM UTC by jzaefferer comment:2

Sounds very similar to #8789. The fix here will probably fix both: https://github.com/jquery/jquery-ui/pull/828

Still not sure what exactly is happening.

Changed November 26, 2012 09:30AM UTC by Jörn Zaefferer comment:3

resolution: → fixed
status: openclosed

Dialog: Don't focus dialog when mousedown is on close button. Fixes #8838 - Dialog: Close icon does not work in dialog larger than the window in IE.

Changeset: 60486ac632a0a1bbbb0c7449fe17bccfae11af80