#8848 closed bug (fixed)
Build: release.js fails to require shelljs/global
| Reported by: | Jörn Zaefferer | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | git |
| Component: | [meta] ui.build | Version: | git (not yet released) |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description (last modified by )
Trying to release 1.9.2. Running node release.js fails here: https://github.com/jquery/jquery-ui/blob/8def77cb5cfefb733874d15a2294f02fc5ae78ae/build/release/release.js#L353
Error: Cannot find module 'shelljs/global'
Its installed in __release/node_modules. I guess it doesn't work because the dependency is installed inside the __release folder, but require runs one level higher up.
Installing shelljs globally doesn't help either.
When doing the 1.9.1 release, I ended up with shelljs 0.0.8. I tried installing that version, didn't make a difference.
Change History (10)
comment:1 Changed 10 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 10 years ago by
| Status: | new → open |
|---|
comment:3 Changed 10 years ago by
| Description: | modified (diff) |
|---|
comment:4 Changed 10 years ago by
comment:5 Changed 10 years ago by
While on it, update the Trac update instructions to mention timezone adjustment. Need to take Trac server time into account.
comment:6 Changed 10 years ago by
| Description: | modified (diff) |
|---|
comment:7 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | open → closed |
Build: Install shell dependencies in the right direcytory. Update trac instructions to point out that only minutes and seconds need to be changed. Fixes #8848 - Build: release.js fails to require shelljs/global.
Changeset: 62ae078f1472b15cd6513eceeff2b9d270b94d46
comment:8 Changed 10 years ago by
Build: Install shell dependencies in the right direcytory. Update trac instructions to point out that only minutes and seconds need to be changed. Fixes #8848 - Build: release.js fails to require shelljs/global. (cherry picked from commit 62ae078f1472b15cd6513eceeff2b9d270b94d46)
Changeset: f919657923f822b891d661fb216884c587e5759b
comment:9 Changed 10 years ago by
| Version: | 1.9.1 → git |
|---|
Changing version to git as there's no need for this in the changelog.
comment:10 Changed 10 years ago by
| Milestone: | 1.10.0 → git |
|---|
It's the milestone, not the version, that matters for the changelog :-)
Installing in the working directory helps. Just need to remove the cwd-argument to the npm-install exec call.