Opened 4 years ago

Closed 4 years ago

#8927 closed bug (fixed)

Menu: Can't change icons option after init

Reported by: scottgonzalez Owned by:
Priority: minor Milestone: 1.10.0
Component: Version: 1.9.2
Keywords: Cc:
Blocked by: Blocking:


Change History (4)

comment:1 Changed 4 years ago by scottgonzalez

  • Status changed from new to open

comment:2 Changed 4 years ago by jzaefferer

The "menus" and "role" options can't be changed after init either. "position" should be fine as that applies the next time a submenu is opened, unless the expectation would be to reposition an open submenu when the position option is updated. Is it? I'd like confirmation on that (and new tickets, if necessary) before addressing this one, since there's no _setOption in menu, yet. Would handle them all at once.

comment:3 Changed 4 years ago by scottgonzalez

I think we need to start making explicit exceptions for certain options being able to be changed after init.

menus: I don't think we should let users change options that deal with how the widget's structure is created. This is similar to accordion's header option.

role: I know some users re-use dialogs, so I could see someone wanting to change the role on a dialog (if we ever let that be customizable so you can have an alertdialog). I'm inclined to say that we don't allow changing this, and wait for good use cases to come in (if there are any).

position: We do re-position dialogs if they're open, but I think that's a pretty different situation from an open menu or open autocomplete. I'd say that changing the position while the menu is open shouldn't do anything until the next submenu is opened.

So, unless there are objections, I'd say icons is the only option to be handled.

comment:4 Changed 4 years ago by Jörn Zaefferer

  • Resolution set to fixed
  • Status changed from open to closed

Menu: Allow changing icons option after creation. Fixes #8927 - Menu: Can't change icons option after init

Changeset: 2c3d311f90281e95827708e2e8d0e52832a437de

Note: See TracTickets for help on using tickets.