Dialog: broken focusin event handler when beforeclose event of a modal opens another modal

[mziech]

When opening a modal dialog within the beforeclose event handler of another modal dialog, a stale focusin event handler remains after all dialogs are closed. An error will occur on the first focus event after the dialogs were closed.

The following example was tested in Chromium 23.0.1271.97 and Firefox 18.0.1 and will output an error message to the console: ​http://jsfiddle.net/gZETu/6/

While debugging into this, I figured out that the focusin event is obviously registered within the namespace of the first dialog (dialog0). After closing the second dialog, it tries to deregister the focusin event within the wrong namespace, the one of the second dialog (dialog4). This leaves the stale event handler registered.

[mziech]

I already implemented a unit test you could use to verify this bug: ​http://jsfiddle.net/gZETu/7/

[tj.vantoll]

Confirmed against master and minified a bit ​http://jsfiddle.net/tj_vantoll/5gyZw/.

[Scott González]

Dialog: Don't use ._on() for modal event handlers. Fixes #9048 - Dialog: broken focusin event handler when beforeclose event of a modal opens another modal.

Changeset: 8724092e5070125e2610e8b0e6ee9ada126cf504