Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#9126 closed bug (fixed)

.show()/.hide() do not support all of core's options

Reported by: albi Owned by:
Priority: minor Milestone: 1.10.2
Component: ui.effects.core Version: 1.10.1
Keywords: Cc:
Blocked by: Blocking:

Description

.hide() and .show() are refined in jquery ui not just extended !! this cause them to break some of their functionalities like STEP function;

http://jsfiddle.net/L5JV7/1/

Change History (5)

comment:1 Changed 7 years ago by tj.vantoll

Component: ui.effects.* (individual effect)ui.effects.core
Status: newopen
Summary: Jquery UI breaks jQuery .hide and .show().show()/.hide() do not support all of core's options

comment:2 Changed 7 years ago by Scott González

Resolution: fixed
Status: openclosed

Effects: Handle the .hide/show/toggle( options ) signatures from core properly. Fixes #9126 - .show()/.hide() do not support all of core's options.

Changeset: 6f2957743659387f66c9b8953bba9fac5617a440

comment:3 Changed 7 years ago by Scott González

Milestone: none1.10.2

comment:4 Changed 6 years ago by sJoris

This is still a bug in the latest jQuery UI 1.11.0 if you use the property effect to change the show/hide-effect. Then the 'step' and 'progress' functions stop working.

See: http://jsfiddle.net/eoqrkL88/

So the Unit test https://github.com/jquery/jquery-ui/blob/master/tests/unit/effects/effects_core.js on line 21 (.hide() with step) should also be changed or some extra tests should be added.

comment:5 Changed 6 years ago by Scott González

Please file a separate issue as this is about adding feature parity to jQuery UI effects, not about broken features from jQuery Core.

Last edited 6 years ago by Scott González (previous) (diff)
Note: See TracTickets for help on using tickets.