Opened 4 years ago

Closed 19 months ago

Last modified 19 months ago

#9151 closed bug (fixed)

Widget: init option disabled: true behaves differently from method disabled

Reported by: mikesherov Owned by: mikesherov
Priority: minor Milestone: 1.12.0
Component: ui.widget Version: 1.10.1
Keywords: Cc:
Blocked by: Blocking:

Change History (26)

comment:1 Changed 4 years ago by tj.vantoll

Owner: set to mikesherov
Status: newpending

mikesherov, this is fixed now correct? http://jsfiddle.net/tj_vantoll/aTHBb/

comment:2 Changed 4 years ago by Scott González

Status: pendingopen

That's showing specific widgets handling it properly. This ticket is about the base widget providing explicit handling for changes to the disabled option, but not doing anything when a widget is initialized with { disabled: true }.

comment:3 Changed 2 years ago by Scott González

The proposed solution is to add a setOptionDisabled() method and call it from create() and setOption().

comment:4 Changed 19 months ago by Scott González

Resolution: fixed
Status: openclosed

Widget: Call ._setOptionDisabled() on init if the widget is disabled

Fixes #9151 Ref gh-1599

Changeset: 7dde5c9d75148cdca7cf86ff0c6e310fdc5a4054

comment:5 Changed 19 months ago by Jörn Zaefferer

Accordion: Handle disabled option on create, through _setOptionDisabled

Ref #9151 Ref gh-1599

Changeset: 874b4a0316b262edaf184a9ddbef539bb6496082

comment:6 Changed 19 months ago by Scott González

Milestone: none1.12.0

comment:7 Changed 19 months ago by Jörn Zaefferer

Dialog: Override disabled option on create, force always-enabled state

Without this, _on will still respect the disabled option and ends up preventing closing the dialog.

Ref #9151 Ref gh-1599

Changeset: 11bd6d28b795971aa55efccfaf69c4e6b5fde629

comment:8 Changed 19 months ago by Jörn Zaefferer

Draggable: Remove redundant handling of disabled class on create

_setOptionDisabled in $.Widget is now handling that.

Ref #9151 Ref gh-1599

Changeset: 83725a8fab70e1483b4001437e50ff0cb29df73b

comment:9 Changed 19 months ago by Jörn Zaefferer

Menu: Remove redundant handling of disabled option on create

Ref #9151 Ref gh-1599

Changeset: 8d031215c6cf62f6fc6d9c9257d1e3c2d4f8b24a

comment:10 Changed 19 months ago by Jörn Zaefferer

Progressbar: Handle disabled option on create, using _setOptionDisabled

Ref #9151 Ref gh-1599

Changeset: 7ceaa618421dc2be3bdb5f5cf8f62d499e982244

comment:11 Changed 19 months ago by Jörn Zaefferer

Selectmenu: Remove redundant handling of disabled option on create

Ref #9151 Ref gh-1599

Changeset: d2f62041f97f5cc31f191c4f5e155e336a035878

comment:12 Changed 19 months ago by Jörn Zaefferer

Slider: Remove redundant handling of disabled option on create

Ref #9151 Ref gh-1599

Changeset: 897dc718c61fdfe3c40c9a8b24c89128bbfe13aa

comment:13 Changed 19 months ago by Jörn Zaefferer

Spinner: Remove redundant handling of disabled option on create

Ref #9151 Ref gh-1599

Changeset: 1397ce4df68e65cb4d417e34e12f13908798234c

comment:14 Changed 19 months ago by Jörn Zaefferer

Tooltip: Don't apply disabled style changes on create

Ref #9151 Ref gh-1599

Changeset: ef8ac2a9f2a98600a029553e45cbde42ca179066

comment:15 Changed 19 months ago by Jörn Zaefferer

Tabs: Adjust handling of disabled option, using _setOptionDisabled

Tabs support multiple values to disable individual tabs. Only add the ui-tabs-disabled class when all tabs are disabled.

Ref #9151 Closes gh-1599

Changeset: 0bfbd21d4fefa98d165b7d50277bd23be84e919a

comment:16 Changed 19 months ago by Scott González

Widget: Call ._setOptionDisabled() on init if the widget is disabled

Fixes #9151 Ref gh-1599

Changeset: 7dde5c9d75148cdca7cf86ff0c6e310fdc5a4054

comment:17 Changed 19 months ago by Jörn Zaefferer

Accordion: Handle disabled option on create, through _setOptionDisabled

Ref #9151 Ref gh-1599

Changeset: 874b4a0316b262edaf184a9ddbef539bb6496082

comment:18 Changed 19 months ago by Jörn Zaefferer

Dialog: Override disabled option on create, force always-enabled state

Without this, _on will still respect the disabled option and ends up preventing closing the dialog.

Ref #9151 Ref gh-1599

Changeset: 11bd6d28b795971aa55efccfaf69c4e6b5fde629

comment:19 Changed 19 months ago by Jörn Zaefferer

Draggable: Remove redundant handling of disabled class on create

_setOptionDisabled in $.Widget is now handling that.

Ref #9151 Ref gh-1599

Changeset: 83725a8fab70e1483b4001437e50ff0cb29df73b

comment:20 Changed 19 months ago by Jörn Zaefferer

Menu: Remove redundant handling of disabled option on create

Ref #9151 Ref gh-1599

Changeset: 8d031215c6cf62f6fc6d9c9257d1e3c2d4f8b24a

comment:21 Changed 19 months ago by Jörn Zaefferer

Progressbar: Handle disabled option on create, using _setOptionDisabled

Ref #9151 Ref gh-1599

Changeset: 7ceaa618421dc2be3bdb5f5cf8f62d499e982244

comment:22 Changed 19 months ago by Jörn Zaefferer

Selectmenu: Remove redundant handling of disabled option on create

Ref #9151 Ref gh-1599

Changeset: d2f62041f97f5cc31f191c4f5e155e336a035878

comment:23 Changed 19 months ago by Jörn Zaefferer

Slider: Remove redundant handling of disabled option on create

Ref #9151 Ref gh-1599

Changeset: 897dc718c61fdfe3c40c9a8b24c89128bbfe13aa

comment:24 Changed 19 months ago by Jörn Zaefferer

Spinner: Remove redundant handling of disabled option on create

Ref #9151 Ref gh-1599

Changeset: 1397ce4df68e65cb4d417e34e12f13908798234c

comment:25 Changed 19 months ago by Jörn Zaefferer

Tooltip: Don't apply disabled style changes on create

Ref #9151 Ref gh-1599

Changeset: ef8ac2a9f2a98600a029553e45cbde42ca179066

comment:26 Changed 19 months ago by Jörn Zaefferer

Tabs: Adjust handling of disabled option, using _setOptionDisabled

Tabs support multiple values to disable individual tabs. Only add the ui-tabs-disabled class when all tabs are disabled.

Ref #9151 Closes gh-1599

Changeset: 0bfbd21d4fefa98d165b7d50277bd23be84e919a

Note: See TracTickets for help on using tickets.