Skip to main content

Search and Top Navigation

#9151 closed bug (fixed)

Opened March 12, 2013 01:35AM UTC

Closed September 25, 2015 05:47PM UTC

Last modified September 27, 2015 04:48AM UTC

Widget: init option disabled: true behaves differently from method disabled

Reported by: mikesherov Owned by: mikesherov
Priority: minor Milestone: 1.12.0
Component: ui.widget Version: 1.10.1
Keywords: Cc:
Blocked by: Blocking:
Attachments (0)
Change History (26)

Changed March 23, 2013 11:28AM UTC by tj.vantoll comment:1

owner: → mikesherov
status: newpending

mikesherov, this is fixed now correct? http://jsfiddle.net/tj_vantoll/aTHBb/

Changed March 25, 2013 02:35PM UTC by scottgonzalez comment:2

status: pendingopen

That's showing specific widgets handling it properly. This ticket is about the base widget providing explicit handling for changes to the disabled option, but not doing anything when a widget is initialized with { disabled: true }.

Changed February 17, 2015 07:58PM UTC by scottgonzalez comment:3

The proposed solution is to add a setOptionDisabled() method and call it from create() and setOption().

Changed September 25, 2015 05:47PM UTC by Scott González comment:4

resolution: → fixed
status: openclosed

Widget: Call ._setOptionDisabled() on init if the widget is disabled

Fixes #9151

Ref gh-1599

Changeset: 7dde5c9d75148cdca7cf86ff0c6e310fdc5a4054

Changed September 25, 2015 05:48PM UTC by Jörn Zaefferer comment:5

Accordion: Handle disabled option on create, through _setOptionDisabled

Ref #9151

Ref gh-1599

Changeset: 874b4a0316b262edaf184a9ddbef539bb6496082

Changed September 25, 2015 05:48PM UTC by scottgonzalez comment:6

milestone: none1.12.0

Changed September 25, 2015 05:48PM UTC by Jörn Zaefferer comment:7

Dialog: Override disabled option on create, force always-enabled state

Without this, _on will still respect the disabled option and ends up

preventing closing the dialog.

Ref #9151

Ref gh-1599

Changeset: 11bd6d28b795971aa55efccfaf69c4e6b5fde629

Changed September 25, 2015 05:49PM UTC by Jörn Zaefferer comment:8

Draggable: Remove redundant handling of disabled class on create

_setOptionDisabled in $.Widget is now handling that.

Ref #9151

Ref gh-1599

Changeset: 83725a8fab70e1483b4001437e50ff0cb29df73b

Changed September 25, 2015 05:49PM UTC by Jörn Zaefferer comment:9

Menu: Remove redundant handling of disabled option on create

Ref #9151

Ref gh-1599

Changeset: 8d031215c6cf62f6fc6d9c9257d1e3c2d4f8b24a

Changed September 25, 2015 05:50PM UTC by Jörn Zaefferer comment:10

Progressbar: Handle disabled option on create, using _setOptionDisabled

Ref #9151

Ref gh-1599

Changeset: 7ceaa618421dc2be3bdb5f5cf8f62d499e982244

Changed September 25, 2015 05:50PM UTC by Jörn Zaefferer comment:11

Selectmenu: Remove redundant handling of disabled option on create

Ref #9151

Ref gh-1599

Changeset: d2f62041f97f5cc31f191c4f5e155e336a035878

Changed September 25, 2015 05:51PM UTC by Jörn Zaefferer comment:12

Slider: Remove redundant handling of disabled option on create

Ref #9151

Ref gh-1599

Changeset: 897dc718c61fdfe3c40c9a8b24c89128bbfe13aa

Changed September 25, 2015 05:51PM UTC by Jörn Zaefferer comment:13

Spinner: Remove redundant handling of disabled option on create

Ref #9151

Ref gh-1599

Changeset: 1397ce4df68e65cb4d417e34e12f13908798234c

Changed September 25, 2015 05:52PM UTC by Jörn Zaefferer comment:14

Tooltip: Don't apply disabled style changes on create

Ref #9151

Ref gh-1599

Changeset: ef8ac2a9f2a98600a029553e45cbde42ca179066

Changed September 25, 2015 05:52PM UTC by Jörn Zaefferer comment:15

Tabs: Adjust handling of disabled option, using _setOptionDisabled

Tabs support multiple values to disable individual tabs. Only add the

ui-tabs-disabled class when all tabs are disabled.

Ref #9151

Closes gh-1599

Changeset: 0bfbd21d4fefa98d165b7d50277bd23be84e919a

Changed September 27, 2015 04:42AM UTC by Scott González comment:16

Widget: Call ._setOptionDisabled() on init if the widget is disabled

Fixes #9151

Ref gh-1599

Changeset: 7dde5c9d75148cdca7cf86ff0c6e310fdc5a4054

Changed September 27, 2015 04:43AM UTC by Jörn Zaefferer comment:17

Accordion: Handle disabled option on create, through _setOptionDisabled

Ref #9151

Ref gh-1599

Changeset: 874b4a0316b262edaf184a9ddbef539bb6496082

Changed September 27, 2015 04:43AM UTC by Jörn Zaefferer comment:18

Dialog: Override disabled option on create, force always-enabled state

Without this, _on will still respect the disabled option and ends up

preventing closing the dialog.

Ref #9151

Ref gh-1599

Changeset: 11bd6d28b795971aa55efccfaf69c4e6b5fde629

Changed September 27, 2015 04:44AM UTC by Jörn Zaefferer comment:19

Draggable: Remove redundant handling of disabled class on create

_setOptionDisabled in $.Widget is now handling that.

Ref #9151

Ref gh-1599

Changeset: 83725a8fab70e1483b4001437e50ff0cb29df73b

Changed September 27, 2015 04:44AM UTC by Jörn Zaefferer comment:20

Menu: Remove redundant handling of disabled option on create

Ref #9151

Ref gh-1599

Changeset: 8d031215c6cf62f6fc6d9c9257d1e3c2d4f8b24a

Changed September 27, 2015 04:45AM UTC by Jörn Zaefferer comment:21

Progressbar: Handle disabled option on create, using _setOptionDisabled

Ref #9151

Ref gh-1599

Changeset: 7ceaa618421dc2be3bdb5f5cf8f62d499e982244

Changed September 27, 2015 04:45AM UTC by Jörn Zaefferer comment:22

Selectmenu: Remove redundant handling of disabled option on create

Ref #9151

Ref gh-1599

Changeset: d2f62041f97f5cc31f191c4f5e155e336a035878

Changed September 27, 2015 04:46AM UTC by Jörn Zaefferer comment:23

Slider: Remove redundant handling of disabled option on create

Ref #9151

Ref gh-1599

Changeset: 897dc718c61fdfe3c40c9a8b24c89128bbfe13aa

Changed September 27, 2015 04:47AM UTC by Jörn Zaefferer comment:24

Spinner: Remove redundant handling of disabled option on create

Ref #9151

Ref gh-1599

Changeset: 1397ce4df68e65cb4d417e34e12f13908798234c

Changed September 27, 2015 04:47AM UTC by Jörn Zaefferer comment:25

Tooltip: Don't apply disabled style changes on create

Ref #9151

Ref gh-1599

Changeset: ef8ac2a9f2a98600a029553e45cbde42ca179066

Changed September 27, 2015 04:48AM UTC by Jörn Zaefferer comment:26

Tabs: Adjust handling of disabled option, using _setOptionDisabled

Tabs support multiple values to disable individual tabs. Only add the

ui-tabs-disabled class when all tabs are disabled.

Ref #9151

Closes gh-1599

Changeset: 0bfbd21d4fefa98d165b7d50277bd23be84e919a