#9621 closed bug (fixed)

Opened October 26, 2013 08:57PM UTC

Closed November 04, 2014 05:08PM UTC

Last modified February 09, 2015 04:53PM UTC

Tabs: Ctrl-Arrow key navigation does not work on OS X Mavericks

Reported by:	dylanb	Owned by:	dylanb
Priority:	minor	Milestone:	1.11.3
Component:	ui.tabs	Version:	1.10.3
Keywords:	a11y	Cc:
Blocked by:		Blocking:

Description

Ctrl-LEFT switches the display and Ctrl-RIGHT is totally ignored.

My recommendation would be to make the non-activation the default keyboard behavior i.e. a user would have to press left or right AND then Enter (or Space) to activate the tab.

Attachments (0)

Change History (10)

Changed October 26, 2013 10:17PM UTC by tj.vantoll comment:1

owner:	→ dylanb
status:	new → pending

Hi dylanb,

I'm not sure what you mean by this, the tabs control does not use Ctrl + LEFT or Ctrl + RIGHT. Is there some issue with using the left and right arrows as activation keys?

Changed October 26, 2013 10:37PM UTC by scottgonzalez comment:2

Well, this is a docs issue as well ;-) Navigating with CTRL prevents automatic activation, but it looks like we never documented that. This came from a recommendation by Hans Hillen: https://github.com/jquery/jquery-ui/pull/666#issuecomment-5981773

@dylanb Can you read through the long discussion in that PR to see why we ended up with what we have today and then let us know if you still think we should change? If you do, we can open up that discussion again.

Changed October 27, 2013 03:15PM UTC by dylanb comment:3

status:	pending → new

@scott.gonzalez - the documentation issue is one problem, the inconsistency with the datepicker (which uses Command) is another issue and then the fact that OS X interprets Ctrl-LEFT and Ctrl-RIGHT as a mechanism to switch virtual displays (and hence does not send these commands to the browser at all) is another problem.

The discussion with Hans is valid. Hans' recommendations are all spot on, so if the decision has been to use some combination of keys to address the timing/activation problem, then we should probably just change the Ctrl to add support for Meta (as with the datepicker) and update the documentation. We may want to go through all the widgets and make similar changes to al of them.

Additionally, to avoid JAWS popping out of forms mode on the tabs, we should add SPACE as a method for activating the tab in addition to ENTER.

Changed October 27, 2013 03:39PM UTC by scottgonzalez comment:4

status:	new → open
summary:	Tab Ctrl-Arrow key navigation does not work on OS X Mavericks → Tabs: Ctrl-Arrow key navigation does not work on OS X Mavericks

That sounds reasonable. We already handle SPACE to activate; we treat it differently than ENTER because ENTER will always toggle, while SPACE will only activate (never collapse).

Changed October 27, 2013 04:00PM UTC by dylanb comment:5

Should treat SPACE exactly the same as ENTER - otherwise the forms mode problem still exists for the collapse functionality

Changed January 09, 2014 09:46AM UTC by scottgonzalez comment:6

keywords:	→ a11y

Changed November 04, 2014 05:08PM UTC by Scott González comment:7

resolution:	→ fixed
status:	open → closed

Tabs: Suppress automatic activation when navigating with COMMAND

Fixes #9621

Closes gh-1383

Changeset: 6a242ab4ebdcec265826b959fa27881dcf462c96

Changed November 04, 2014 05:16PM UTC by scottgonzalez comment:8

milestone:	none → 1.12.0

Changed February 09, 2015 04:52PM UTC by Scott González comment:9