Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#9671 closed bug (fixed)

Draggable: iframeFix doesn't handle iframes that move

Reported by: fejesjoco Owned by: mikesherov
Priority: minor Milestone: 1.11.2
Component: ui.draggable Version: 1.10.3
Keywords: Cc:
Blocked by: Blocking:

Description

I created a very basic fiddle here: http://jsfiddle.net/5w34F/ (it uses an older version of jquery-ui, but it's the same as in 1.10.3).

When you are dragging, and do a sudden mouse movement, if the mouse pointer ends up inside the iframe, the dragging is suspended. AFAIK iframeFix should fix exactly that, but it doesn't.

I changed jquery-ui source code so that the iframeFix div's opacity is 1 (instead of 0.001) and it's color is yellow (instead of white). You can clearly see that the yellow fixer div remains at its initial position and doesn't move along with the iframe. Moreover, if I add a stack: "div" option, the fixer div's z-index will be too low and it will be behind the iframe.

Change History (7)

comment:1 Changed 3 years ago by scottgonzalez

  • Status changed from new to open
  • Summary changed from draggable iframefix doesn't work to Draggable: iframeFix doesn't handle iframes that move

We should copy the new implementation from the interactions branch.

comment:2 Changed 3 years ago by fejesjoco

About the title change: the iframe doesn't actually move in itself, it moves only because of the dragging, but in this respect, all iframes move.

comment:3 Changed 3 years ago by scottgonzalez

That's not true that all iframes move. Most iframes don't move relative to the top left corner of the document. This one does.

comment:4 Changed 3 years ago by fejesjoco

Sorry, you're right, I thought iframeFix is supposed to handle iframes inside the draggable area, now I see this rather applies to iframes outside of it. In this case I guess it's rather a feature request, but I'm very happy to hear that a new branch supports both cases.

comment:5 Changed 3 years ago by scottgonzalez

  • Owner set to mikesherov
  • Status changed from open to assigned

comment:6 Changed 3 years ago by Mike Sherov

  • Resolution set to fixed
  • Status changed from assigned to closed

Draggable: append divs to iframe parent for iframefix

This allows the blocking div to move with the iframe in most situations, whereas appending to the body wouldn't.

Fixes #9671

Changeset: c7bec85cfa7711bb2612278eb980d0d14dade3b9

comment:7 Changed 3 years ago by mikesherov

  • Milestone changed from none to 1.11.2
Note: See TracTickets for help on using tickets.