Opened 5 years ago
Closed 4 years ago
#9845 closed feature (worksforme)
Make use of box-sizing: border-box
| Reported by: | Jörn Zaefferer | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.12.0 |
| Component: | [meta] ui.dev | Version: | 1.10.4 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
IE7 was the last browser we supported that didn't support border-box. Once we've branched 1-11-stable, we can start making use of border-box. That should help simplify the _size method in dialog. There's likely more.
Change History (3)
comment:1 Changed 5 years ago by
| Milestone: | none → 1.12.0 |
|---|---|
| Status: | new → open |
comment:2 Changed 5 years ago by
comment:3 Changed 4 years ago by
| Resolution: | → worksforme |
|---|---|
| Status: | open → closed |
I just reverted that dialog commit and tested in Chrome and Opera (20). Chrome works fine, Opera fails. Adding border-box to .ui-dialog makes it worse. I also don't see how border-box would help simplify dialog's _size method.
We don't need this ticket as a reminder to use box-sizing, so I'll just close this.
Note: See
TracTickets for help on using
tickets.
Dialog: Work around subpixel issues in dialog resizable test
Switching to checking the size of the content element. We should be checking the dimensions of the .ui-dialog element, but that currently fails in Chromium-based browsers. Once we start using box-sizing: border-box, we should try to revert this change.
Ref #9845