Opened 3 years ago

Closed 3 years ago

#9991 closed bug (fixed)

Menu: Scroll on cursor down doesn't fully show the newly focused item

Reported by: jzaefferer Owned by:
Priority: major Milestone: 1.11.0
Component: ui.menu Version: git (not yet released)
Keywords: regression Cc:
Blocked by: Blocking:

Description

This works fine in 1.10.4 with the old menu style: http://view.jqueryui.com/1.10.4/demos/autocomplete/maxheight.html

Its broken in master: http://view.jqueryui.com/master/demos/autocomplete/maxheight.html

To reproduce, type "a", then cursor down 6 times.

Can also be seen on the scrollable menu on the visual test page for menu: http://view.jqueryui.com/master/tests/visual/menu/menu.html

This was introduced with the new menu style: https://github.com/jquery/jquery-ui/commit/9910e938aad1090339a2c7f60693093ee18aba82

Change History (3)

comment:1 Changed 3 years ago by jzaefferer

  • Milestone changed from none to 1.11.0
  • Priority changed from minor to major
  • Status changed from new to open
  • Version changed from 1.10.4 to git

This also affect selectmenu.

comment:2 Changed 3 years ago by jzaefferer

  • Keywords regression added

comment:3 Changed 3 years ago by Jörn Zaefferer

  • Resolution set to fixed
  • Status changed from open to closed

Menu: Use item.outerHeight() in _scrollIntoView

Fixes #9991

Changeset: b22280385c05eaf10f4d480c546906b85aa011e1

Note: See TracTickets for help on using tickets.