Opened 3 years ago

Closed 3 years ago

#9995 closed bug (fixed)

Menu: Rendering issues in IE8

Reported by: jzaefferer Owned by:
Priority: major Milestone: 1.11.0
Component: ui.menu Version: git (not yet released)
Keywords: regression Cc:
Blocked by: Blocking:

Description

Looking at the default demo in master, there are several rendering issues that don't show up in Chrome.

  • Disabled items after an item with a submenu doesn't span the full length of the menu. It looks like the missing part is about the width of the submenu icon. This doesn't happen for other disabled items. In the default demo, the first item looks fine, the last doesn't.
  • While moving focus through the menu, a somewhat subtle 1px shift can be observed. Its not moving much, but its pretty annoying anyway.

None of these appear in 1.10.4, so I currently assume they were introduced by the menu style overhaul.

Change History (4)

comment:1 Changed 3 years ago by jzaefferer

  • Keywords regression added
  • Milestone changed from none to 1.11.0
  • Priority changed from minor to major
  • Status changed from new to open

comment:2 Changed 3 years ago by tj.vantoll

I can confirm this occurs in 1.11, and that this works fine in IE9+. The problem appears to be related to this negative margin: https://github.com/jquery/jquery-ui/blob/516920ac71902cb9349db2220b5f7eb8e357340e/themes/base/menu.css#L39. Although that line was applied to the anchor tags before, so I'm not sure what's up.

comment:4 Changed 3 years ago by Trisha Crowley

  • Resolution set to fixed
  • Status changed from open to closed

Menu: Vertically center icons. Fix menu item wiggle and clearing in IE8

Fixes #9995 Closes gh-1235

Changeset: b0e8380f023f41cb4a1bd3665177b5f0e795c289

Note: See TracTickets for help on using tickets.