#5767 closed bug (fixed)

Opened June 24, 2010 02:58PM UTC

Closed July 16, 2010 08:58PM UTC

Last modified November 19, 2010 06:26PM UTC

On open, the first tabbable element inside the dialog was never being focused in favor of the dialog container.

Reported by: ajcrews Owned by:
Priority: major Milestone: 1.8.3
Component: ui.dialog Version: 1.8.2
Keywords: focus tabbable Cc:
Blocked by: Blocking:
Description

Within the "open" method in ui.dialog, there is an attempt to "set focus to the first tabbable element in the content area or the first button. if there are no tabbable elements, set focus on the dialog itself".

This was being accomplished using the jQuery "add" method, and was working up until jQuery 1.4.x, since: "As of jQuery 1.4 the results from .add() will always be returned in document order" (http://api.jquery.com/add).

Also, in Firefox 3.6.x, the dialog will not show if a tabbable element is focused in the "open" method.

Attachments (0)
Change History (8)

Changed June 24, 2010 02:59PM UTC by ajcrews comment:1

Related tickets: #4421, #4675

Changed June 24, 2010 06:00PM UTC by ajcrews comment:3

Replying to [comment:2 ajcrews]:

Fixed: http://github.com/ajcrews/jquery-ui/commit/74157f83906a23814cdf6d13c20d83253c8b41bc

I had code in place to handle a race condition I was unaware of - the race condition is caused by setting the "show" option to an animation like "fade". I have addressed that issue as well.

Related tickets, bundled together: #4421, #4675, #4731

Fixed: http://github.com/ajcrews/jquery-ui/commit/1d1de7fc70501c25c6ff3de204c04078602baa04

Changed June 24, 2010 06:49PM UTC by ajcrews comment:4

Final version: http://github.com/ajcrews/jquery-ui/commit/1d1de7fc70501c25c6ff3de204c04078602baa04

Changed June 24, 2010 06:52PM UTC by ajcrews comment:5

Sorry, wrong link to Final version: http://github.com/ajcrews/jquery-ui/commit/405574d93211e2a419062ac0e39cbf9baefc79a8

Changed July 16, 2010 08:58PM UTC by scottgonzalez comment:6

milestone: TBD → 1.9
priority: minor → major
resolution: → fixed
status: new → closed

Fixed in 64d90b4.

Changed August 04, 2010 01:24AM UTC by scottgonzalez comment:7

milestone: 1.9 → 1.8.3

Changed November 19, 2010 06:26PM UTC by Scott González comment:8

Dialog: Adjusted logic for finding the first tabbable element. Fixes #5767 - On open, the first tabbable element inside the dialog was never being focused in favor of the dialog container.

Changeset: 64d90b4a710d520a44408ccfa8df1100b0b95b4d