#7041 closed bug (fixed)

Opened February 26, 2011 08:56AM UTC

Closed December 10, 2014 10:00PM UTC

Toggle size effect demo not working

Reported by: eccenux Owned by: mikesherov
Priority: minor Milestone: 1.12.0
Component: ui.effects.* (individual effect) Version: 1.8.9
Keywords: Cc:
Blocked by: Blocking:
Description

Steps

1. Open page toggle demo.

2. Select size effect.

3. Click twice on Run effect.

Result

Background is not scaled back to the original size.

Not sure if this is a problem with demo options or with the "size" effect. Are there any options to make it work right?

Expected result

Toggle to the original size.

Attachments (0)
Change History (12)

Changed February 26, 2011 09:48AM UTC by scottgonzalez comment:1

component: [meta] ui.demos → effects.* (individual effect)

Changed May 05, 2011 01:10AM UTC by kzys comment:2

https://github.com/jquery/jquery-ui/pull/203

Changed May 05, 2011 01:54AM UTC by gnarf comment:3

_comment0: Reviewing the pull by kzys has got me wondering if {{{ .toggle("size") }}} makes any sense. We should at minimum document this to/from swapping... \ → 1304560640636623
status: new → open

Reviewing the pull by kzys has got me wondering if 

 .toggle("size")
makes any sense. We should at minimum document this to/from swapping behaviour and limit it to ONLY when using 
 .toggle()
...

Changed May 05, 2011 02:01AM UTC by gnarf comment:4

_comment0: Also - Which direction do you think makes more sense to be {{{ from }}} vs {{{ to }}} ? Showing goes {{{ to -> from }}} ? I would think that Showing goes {{{ from -> to }}} → 1304561539841722
_comment1: Also - Which direction do you think makes more sense to be {{{ from }}} vs {{{ to }}} ? Showing goes {{{ to -> from }}} ? I would think that Showing goes {{{ from -> to }}} and hiding goes {{{ to -> from }}}, but only when your original mode is '''toggle''' → 1304561560564215
_comment2: Also - Which direction do you think makes more sense to be {{{ from }}} vs {{{ to }}} ? Showing goes {{{ to -> from }}} ? \ \ I would think that Showing goes {{{ from -> to }}} and hiding goes {{{ to -> from }}}, but only when your original mode is '''toggle''' → 1304573728670771

Also - Which direction do you think makes more sense to be 

 from
vs 
 to
? Showing goes 
 to -> from
?

I would think that Showing goes 

 from -> to
and hiding goes 
 to -> from
, but only when your original mode is toggle

https://github.com/jquery/jquery-ui/pull/203#commitcomment-369756 might give you a better idea of a use case.

Changed May 05, 2011 02:14AM UTC by gnarf comment:5

owner: → kzys
status: open → assigned

Changed October 11, 2012 02:42PM UTC by scottgonzalez comment:6

milestone: 1.9.0 → 1.10.0

Changed October 18, 2012 01:49AM UTC by mikesherov comment:7

cc: → gnarf, scott.gonzalez

There is a valid pull request still here! It was only closed because it no longer merged cleanly: https://github.com/jquery/jquery-ui/pull/203 If someone can rebase, perhaps it can be rescued... scott?

Changed October 25, 2012 02:13PM UTC by jzaefferer comment:8

Partially fixed in https://github.com/jquery/jquery-ui/commit/5f9d5c54c31546977792f4493b419f6c72fcc93e

Changed January 09, 2013 02:50AM UTC by mikesherov comment:9

keywords: → haspatch

Changed January 25, 2013 09:23PM UTC by tj.vantoll comment:10

milestone: 1.10.0 → none

Changed November 18, 2014 04:28PM UTC by mikesherov comment:11

cc: gnarf, scott.gonzalez
keywords: haspatch
milestone: none → 1.12.0
owner: kzys → mikesherov

This will be fixed by the effects rewrite.

Changed December 10, 2014 10:00PM UTC by Mike Sherov comment:12

resolution: → fixed
status: assigned → closed

Effects: Rewrite

1. Introduces a set of helper methods to easily create and define new effects.

2. Uses clip animations and placeholders instead of wrappers for clip effects.

3. Ensures all animations are detectable as animated

Fixes #10599

Fixes #9477

Fixes #9257

Fixes #9066

Fixes #8867

Fixes #8671

Fixes #8505

Fixes #7885

Fixes #7041

Closes gh-1017

Changeset: b6bec797d6a8ef0b377a866c38c67e66a626b45f