#9477 closed bug (fixed)

Opened August 05, 2013 12:01PM UTC

Closed December 10, 2014 10:00PM UTC

Effect: .ui-effects-wrapper not following element's display, vertical-align, etc. makes trouble

Reported by: euyuil Owned by: mikesherov
Priority: minor Milestone: 1.12.0
Component: ui.effects.core Version: 1.10.3
Keywords: Cc:
Blocked by: Blocking:
Description

Here is a pull request at Github, maybe the discussion will help.

An example shows that currently the latest version of jQuery 1.10.2 and jQuery UI 1.10.3 don't follow element's display property when creating a wrapper for it and make the effect seems wrong. @tjvantoll showed a clearer example.

After that I discovered another example, showing that not following vertical-align property of the element will cause problem too.

So I guess maybe there are even more of them but I haven't found any until now.

Attachments (0)
Change History (6)

Changed December 05, 2013 01:40PM UTC by tj.vantoll comment:1

#9690 is a duplicate of this ticket.

Changed December 05, 2013 01:40PM UTC by tj.vantoll comment:2

status: new → open

When the effects rewrite lands we'll have to see if this is still relevant.

Changed December 08, 2013 01:21AM UTC by mikesherov comment:3

owner: → mikesherov
status: open → assigned

Changed December 08, 2013 01:21AM UTC by mikesherov comment:4

Replying to [comment:2 tj.vantoll]:

When the effects rewrite lands we'll have to see if this is still relevant.

I won't be, but I'm accepting just to make sure :-)

Changed November 18, 2014 06:44PM UTC by mikesherov comment:5

milestone: none → 1.12.0

This is indeed fixed by the effects rewrite.

Changed December 10, 2014 10:00PM UTC by Mike Sherov comment:6

resolution: → fixed
status: assigned → closed

Effects: Rewrite

1. Introduces a set of helper methods to easily create and define new effects.

2. Uses clip animations and placeholders instead of wrappers for clip effects.

3. Ensures all animations are detectable as animated

Fixes #10599

Fixes #9477

Fixes #9257

Fixes #9066

Fixes #8867

Fixes #8671

Fixes #8505

Fixes #7885

Fixes #7041

Closes gh-1017

Changeset: b6bec797d6a8ef0b377a866c38c67e66a626b45f